Bugfix to pass in domainID with AppendHistory call to persistence (ca…

…dence-workflow#126) Pass in domainID with AppendHistory call as part of execution update. Fix error handling issue to return the error if first update to AppendHistory fails with an error.
mudit3774 · Apr 10, 2017 · ed1f4d0 · ed1f4d0
1 parent f9d51a1
commit ed1f4d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/service/history/shardContext.go b/service/history/shardContext.go
@@ -235,7 +235,7 @@ func (s *shardContextImpl) AppendHistoryEvents(request *persistence.AppendHistor
 		}
 	}
 
-	return nil
+	return err0
 }
 
 func (s *shardContextImpl) GetLogger() bark.Logger {

diff --git a/service/history/workflowExecutionContext.go b/service/history/workflowExecutionContext.go
@@ -106,6 +106,7 @@ func (c *workflowExecutionContext) updateWorkflowExecution(transferTasks []persi
 		}
 
 		if err0 := c.shard.AppendHistoryEvents(&persistence.AppendHistoryEventsRequest{
+			DomainID:      c.domainID,
 			Execution:     c.workflowExecution,
 			TransactionID: transactionID,
 			FirstEventID:  firstEvent.GetEventId(),
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     	}
-    	return nil
+    	return err0
     }
     func (s *shardContextImpl) GetLogger() bark.Logger {
@@ Expand Down @@