Use early return instead of two if statements

- Per feedback from @akrabat
muhd7rosli · Dec 19, 2012 · b43c876 · b43c876
1 parent 1682874
commit b43c876
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/library/Zend/Mvc/Controller/AbstractActionController.php b/library/Zend/Mvc/Controller/AbstractActionController.php
@@ -55,13 +55,9 @@ public function notFoundAction()
         $routeMatch->setParam('action', 'not-found');
 
         if ($response instanceof HttpResponse) {
-            $viewModel = $this->createHttpNotFoundModel($response);
+            return $this->createHttpNotFoundModel($response);
         }
-        if (!$response instanceof HttpResponse) {
-            $viewModel = $this->createConsoleNotFoundModel($response);
-        }
-
-        return $viewModel;
+        return $this->createConsoleNotFoundModel($response);
     }
 
     /**