setup: limits: for who and defaults #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
force-pushed
the
limits-details
branch
2 times, most recently
from
0fa34f7 to
4eca5d9
Compare
mjmartineau
approved these changes
Jun 26, 2024
It sounds interesting to add more details about each limit: for who (client/server), and the default value. While at it, use a list. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Not the total number, it can be confusing. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
It is not the first time we have people not understanding why only <X additional subflows have been established, while the limit is X. Co-authored-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Just to be clear that by default, the client will not be able to create an unlimited number of subflows, max 2 additional ones. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds interesting to add more details about each limit: for who (client/server), and the default value.
While at it, use a list.
(Note that I did two small modifications before that: f3adc6b & aa8e152 ; I don't think they needed to be reviewed)
EDIT: + two other improvements