apps: add 'Linux distributions' section #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
force-pushed
the
distributions
branch
from
305d412 to
2ff4415
Compare
|
Please remove my handle from the patch log. It causes both my GitHub and email inbox to fill up with unwanted mentions. You can use "Arınç" instead. |
matttbe
force-pushed
the
distributions
branch
from
2ff4415 to
b386f7e
Compare
mjmartineau
approved these changes
Nov 6, 2024
apps.md
Outdated
| @@ -1,17 +1,17 @@ | |||
| --- | |||
| layout: home | |||
| title: Apps supporting MPTCP | |||
| title: Support in apps / OS | |||
There was a problem hiding this comment.
Suggested change
| title: Support in apps / OS | |
| title: Support in Apps and Operating Systems |
There was a problem hiding this comment.
With this, the title goes on two lines:
I tried to keep it short for that reason, but that's probably fine to have it on two lines. WDYT?
As pointed out by Arınç and Daniel [1], it would be clearer to have a dedicated Linux distributions sections, because OpenWrt is not an application. Here I tried to list most common GNU/Linux distributions, avoiding forks having the same kernel configuration and mptcpd package. Raspbian and Ubuntu have different kernel configurations and are quite popular, it is better to mention them. I decided to add a new section in the 'apps' page, not to create yet another page, while it is linked to the rest. Because it is better not to rename a page to avoid breaking links, I changed the title instead: Support in apps / OS. It covers what is currently in this page, and still linked to 'apps'. Link: #26 [1] Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
matttbe
force-pushed
the
distributions
branch
from
b386f7e to
7ae801f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by arinc9 and dangowrt [1], it would be clearer to have a dedicated Linux distributions sections, because OpenWrt is not an application.
Here I tried to list most common GNU/Linux distributions, avoiding forks having the same kernel configuration and mptcpd package. Raspbian and Ubuntu have different kernel configurations and are quite popular, it is better to mention them.
I decided to add a new section in the 'apps' page, not to create yet another page, while it is linked to the rest.
Because it is better not to rename a page to avoid breaking links, I changed the title instead: Support in apps / OS. It covers what is currently in this page, and still linked to 'apps'.