info: fallback: MPTCP_INFO_FLAG_FALLBACK is never set #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling getsockopt(MPTCP_INFO), MPTCP_INFO_FLAG_FALLBACK will never be set. Instead the syscall will return an error, for both the client and the server side. MPTCP_INFO_FLAG_FALLBACK will only be set when listing MPTCP connections via the Netlink API (hence the confusion). We can simplify the examples now: - getsockopt(MPTCP_INFO) for both the client and server, kernels >= 5.16 - getsockopt(SO_PROTOCOL) for the server only, only check the client request, kernels < 5.16 Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
|
I suggest merging it now, to stop propagating wrong info. We can fix typo later if needed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling getsockopt(MPTCP_INFO), MPTCP_INFO_FLAG_FALLBACK will never be set. Instead the syscall will return an error, for both the client and the server side.
MPTCP_INFO_FLAG_FALLBACK will only be set when listing MPTCP connections via the Netlink API (hence the confusion).
We can simplify the examples now: