Skip to content

Commit

Permalink
[WebAssembly] Fix build error in wasm YAML code
Browse files Browse the repository at this point in the history
This warning didn't show up on my local build
but is causing the bots to fail.  Seems like a
bad idea to have types and variables with the
same name anyhow.

Differential Revision: https://reviews.llvm.org/D33022

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@302606 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
sbc100 committed May 10, 2017
1 parent 4daaa86 commit bde17ff
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions include/llvm/ObjectYAML/WasmYAML.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ struct Import {
ExportKind Kind;
union {
uint32_t SigIndex;
Global Global;
Table Table;
Global GlobalImport;
Table TableImport;
Limits Memory;
};
};
Expand Down
6 changes: 3 additions & 3 deletions lib/ObjectYAML/WasmYAML.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,10 @@ void MappingTraits<WasmYAML::Import>::mapping(IO &IO,
if (Import.Kind == wasm::WASM_EXTERNAL_FUNCTION) {
IO.mapRequired("SigIndex", Import.SigIndex);
} else if (Import.Kind == wasm::WASM_EXTERNAL_GLOBAL) {
IO.mapRequired("GlobalType", Import.Global.Type);
IO.mapRequired("GlobalMutable", Import.Global.Mutable);
IO.mapRequired("GlobalType", Import.GlobalImport.Type);
IO.mapRequired("GlobalMutable", Import.GlobalImport.Mutable);
} else if (Import.Kind == wasm::WASM_EXTERNAL_TABLE) {
IO.mapRequired("Table", Import.Table);
IO.mapRequired("Table", Import.TableImport);
} else if (Import.Kind == wasm::WASM_EXTERNAL_MEMORY ) {
IO.mapRequired("Memory", Import.Memory);
} else {
Expand Down
6 changes: 3 additions & 3 deletions tools/obj2yaml/wasm2yaml.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ ErrorOr<WasmYAML::Object *> WasmDumper::dump() {
Im.SigIndex = Import.SigIndex;
break;
case wasm::WASM_EXTERNAL_GLOBAL:
Im.Global.Type = Import.Global.Type;
Im.Global.Mutable = Import.Global.Mutable;
Im.GlobalImport.Type = Import.Global.Type;
Im.GlobalImport.Mutable = Import.Global.Mutable;
break;
case wasm::WASM_EXTERNAL_TABLE:
Im.Table = make_table(Import.Table);
Im.TableImport = make_table(Import.Table);
break;
case wasm::WASM_EXTERNAL_MEMORY:
Im.Memory = make_limits(Import.Memory);
Expand Down
8 changes: 4 additions & 4 deletions tools/yaml2obj/yaml2wasm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,15 +169,15 @@ int WasmWriter::writeSectionContent(raw_ostream &OS,
encodeULEB128(Import.SigIndex, OS);
break;
case wasm::WASM_EXTERNAL_GLOBAL:
encodeSLEB128(Import.Global.Type, OS);
writeUint8(OS, Import.Global.Mutable);
encodeSLEB128(Import.GlobalImport.Type, OS);
writeUint8(OS, Import.GlobalImport.Mutable);
break;
case wasm::WASM_EXTERNAL_MEMORY:
writeLimits(Import.Memory, OS);
break;
case wasm::WASM_EXTERNAL_TABLE:
encodeSLEB128(Import.Table.ElemType, OS);
writeLimits(Import.Table.TableLimits, OS);
encodeSLEB128(Import.TableImport.ElemType, OS);
writeLimits(Import.TableImport.TableLimits, OS);
break;
default:
errs() << "Unknown import type: " << Import.Kind;
Expand Down

0 comments on commit bde17ff

Please sign in to comment.