Skip to content

Commit

Permalink
Allow "line 0" to be the first explicit debug location in a function.
Browse files Browse the repository at this point in the history
Feedback on r289468 from Adrian Prantl.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290012 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
pogo59 committed Dec 16, 2016
1 parent 980f5c5 commit c8eb7f3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ void DwarfDebug::beginInstruction(const MachineInstr *MI) {
// We have an explicit location, different from the previous location.
// Don't repeat a line-0 record, but otherwise emit the new location.
// (The new location might be an explicit line 0, which we do emit.)
if (DL.getLine() == 0 && LastAsmLine == 0)
if (PrevInstLoc && DL.getLine() == 0 && LastAsmLine == 0)
return;
unsigned Flags = 0;
if (DL == PrologEndLoc) {
Expand Down
7 changes: 6 additions & 1 deletion test/DebugInfo/X86/dbg-prolog-end.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
target triple = "x86_64-apple-macosx10.6.7"

;CHECK-LABEL: foo:
;CHECK: .loc 1 2 11 prologue_end
define i32 @foo(i32 %i) nounwind ssp !dbg !1 {
entry:
Expand All @@ -24,10 +25,13 @@ entry:

declare void @llvm.dbg.declare(metadata, metadata, metadata) nounwind readnone

;CHECK-LABEL: main:
;CHECK: .loc 1 0 0 prologue_end

define i32 @main() nounwind ssp !dbg !6 {
entry:
%retval = alloca i32, align 4
store i32 0, i32* %retval
store i32 0, i32* %retval, !dbg !22
%call = call i32 @foo(i32 21), !dbg !16
ret i32 %call, !dbg !16
}
Expand Down Expand Up @@ -57,3 +61,4 @@ entry:
!19 = !DIFile(filename: "/tmp/a.c", directory: "/private/tmp")
!20 = !{}
!21 = !{i32 1, !"Debug Info Version", i32 3}
!22 = !DILocation(line: 0, column: 0, scope: !17)

0 comments on commit c8eb7f3

Please sign in to comment.