Skip to content

Commit

Permalink
contracts-bedrock: remove LegacyERC20ETH contract (ethereum-optimism#…
Browse files Browse the repository at this point in the history
…9472)

* contracts-bedrock: remove LegacyERC20ETH contract

The `LegacyERC20ETH` is no longer used as part of the genesis
generation. Is a contract that only lives on OP Mainnet and is
no longer used since the bedrock upgrade. It is completely deprecated
at this point and there is no real reason to keep around its source
code since it isn't placed into modern genesis states. It has no
usage anymore and keeping it around only bloats the lines of code
in the contracts, increases the build time and increases the test
time.

* contracts-bedrock: fix build

* op-bindings: remove LegacyERC20ETH

No longer used

* contracts-bedrock: update gas snapshot
  • Loading branch information
tynes authored Feb 13, 2024
1 parent 39bc6f4 commit e7ff5eb
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 1,558 deletions.
1 change: 0 additions & 1 deletion op-bindings/artifacts.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"L1FeeVault",
"OptimismMintableERC20Factory",
"OptimismMintableERC20",
"LegacyERC20ETH",
"Proxy",
"ProxyAdmin",
"LegacyMessagePasser",
Expand Down
1,381 changes: 0 additions & 1,381 deletions op-bindings/bindings/legacyerc20eth.go

This file was deleted.

27 changes: 0 additions & 27 deletions op-bindings/bindings/legacyerc20eth_more.go

This file was deleted.

2 changes: 1 addition & 1 deletion packages/contracts-bedrock/.gas-snapshot
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ GasBenchMark_L1StandardBridge_Finalize:test_finalizeETHWithdrawal_benchmark() (g
GasBenchMark_L2OutputOracle:test_proposeL2Output_benchmark() (gas: 92951)
GasBenchMark_OptimismPortal:test_depositTransaction_benchmark() (gas: 68360)
GasBenchMark_OptimismPortal:test_depositTransaction_benchmark_1() (gas: 68991)
GasBenchMark_OptimismPortal:test_proveWithdrawalTransaction_benchmark() (gas: 155557)
GasBenchMark_OptimismPortal:test_proveWithdrawalTransaction_benchmark() (gas: 155559)
69 changes: 0 additions & 69 deletions packages/contracts-bedrock/src/legacy/LegacyERC20ETH.sol

This file was deleted.

76 changes: 0 additions & 76 deletions packages/contracts-bedrock/test/legacy/LegacyERC20ETH.t.sol

This file was deleted.

3 changes: 0 additions & 3 deletions packages/contracts-bedrock/test/setup/Setup.sol
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { L1Block } from "src/L2/L1Block.sol";
import { LegacyMessagePasser } from "src/legacy/LegacyMessagePasser.sol";
import { GovernanceToken } from "src/governance/GovernanceToken.sol";
import { OptimismMintableERC20Factory } from "src/universal/OptimismMintableERC20Factory.sol";
import { LegacyERC20ETH } from "src/legacy/LegacyERC20ETH.sol";
import { StandardBridge } from "src/universal/StandardBridge.sol";
import { FeeVault } from "src/universal/FeeVault.sol";
import { OptimismPortal } from "src/L1/OptimismPortal.sol";
Expand Down Expand Up @@ -74,7 +73,6 @@ contract Setup {
L1Block l1Block = L1Block(Predeploys.L1_BLOCK_ATTRIBUTES);
LegacyMessagePasser legacyMessagePasser = LegacyMessagePasser(Predeploys.LEGACY_MESSAGE_PASSER);
GovernanceToken governanceToken = GovernanceToken(Predeploys.GOVERNANCE_TOKEN);
LegacyERC20ETH legacyERC20ETH = LegacyERC20ETH(Predeploys.LEGACY_ERC20_ETH);

/// @dev Deploys the Deploy contract without including its bytecode in the bytecode
/// of this contract by fetching the bytecode dynamically using `vm.getCode()`.
Expand Down Expand Up @@ -160,7 +158,6 @@ contract Setup {
governanceToken.transferOwnership(finalSystemOwner);

vm.label(Predeploys.OPTIMISM_MINTABLE_ERC20_FACTORY, "OptimismMintableERC20Factory");
vm.label(Predeploys.LEGACY_ERC20_ETH, "LegacyERC20ETH");
vm.label(Predeploys.L2_STANDARD_BRIDGE, "L2StandardBridge");
vm.label(Predeploys.L2_CROSS_DOMAIN_MESSENGER, "L2CrossDomainMessenger");
vm.label(Predeploys.L2_TO_L1_MESSAGE_PASSER, "L2ToL1MessagePasser");
Expand Down

0 comments on commit e7ff5eb

Please sign in to comment.