Skip to content

Commit

Permalink
Make some skyframe and lib/skyframe classes public.
Browse files Browse the repository at this point in the history
--
MOS_MIGRATED_REVID=99197069
  • Loading branch information
haxorz authored and laszlocsomor committed Jul 28, 2015
1 parent 6976e6c commit 029de3d
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
/**
* A {@link SkyFunction} for {@link DirectoryListingValue}s.
*/
final class DirectoryListingFunction implements SkyFunction {
public final class DirectoryListingFunction implements SkyFunction {

@Override
public SkyValue compute(SkyKey skyKey, Environment env)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,13 @@
import java.util.concurrent.atomic.AtomicReference;

/** Common utilities for dealing with files outside the package roots. */
class ExternalFilesHelper {
public class ExternalFilesHelper {

private final AtomicReference<PathPackageLocator> pkgLocator;
private final Set<Path> immutableDirs;
private final boolean errorOnExternalFiles;

@VisibleForTesting
ExternalFilesHelper(AtomicReference<PathPackageLocator> pkgLocator) {
public ExternalFilesHelper(AtomicReference<PathPackageLocator> pkgLocator) {
this(pkgLocator, ImmutableSet.<Path>of(), /*errorOnExternalFiles=*/false);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
*
* <p>This code drives the glob matching process.
*/
final class GlobFunction implements SkyFunction {
public final class GlobFunction implements SkyFunction {

private final Cache<String, Pattern> regexPatternCache =
CacheBuilder.newBuilder().concurrencyLevel(4).build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@
/**
* SkyFunction for {@link PackageLookupValue}s.
*/
class PackageLookupFunction implements SkyFunction {
public class PackageLookupFunction implements SkyFunction {

private final AtomicReference<ImmutableSet<PackageIdentifier>> deletedPackages;

PackageLookupFunction(AtomicReference<ImmutableSet<PackageIdentifier>> deletedPackages) {
public PackageLookupFunction(AtomicReference<ImmutableSet<PackageIdentifier>> deletedPackages) {
this.deletedPackages = deletedPackages;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ public static <T> Injected injected(Precomputed<T> precomputed, T value) {
return new Injected(precomputed, Suppliers.ofInstance(value));
}

static final Precomputed<String> DEFAULTS_PACKAGE_CONTENTS =
public static final Precomputed<String> DEFAULTS_PACKAGE_CONTENTS =
new Precomputed<>(new SkyKey(SkyFunctions.PRECOMPUTED, "default_pkg"));

static final Precomputed<RuleVisibility> DEFAULT_VISIBILITY =
public static final Precomputed<RuleVisibility> DEFAULT_VISIBILITY =
new Precomputed<>(new SkyKey(SkyFunctions.PRECOMPUTED, "default_visibility"));

static final Precomputed<UUID> BUILD_ID =
Expand Down Expand Up @@ -173,7 +173,7 @@ public T get(SkyFunction.Environment env) {
/**
* Injects a new variable value.
*/
void set(Injectable injectable, T value) {
public void set(Injectable injectable, T value) {
injectable.inject(ImmutableMap.of(key, new PrecomputedValue(value)));
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class WorkspaceFileFunction implements SkyFunction {
private final Path installDir;
private final RuleClassProvider ruleClassProvider;

WorkspaceFileFunction(
public WorkspaceFileFunction(
RuleClassProvider ruleClassProvider,
PackageFactory packageFactory,
BlazeDirectories directories) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public interface Differencer {
/**
* Represents a set of changed values.
*/
interface Diff {
public interface Diff {
/**
* Returns the value keys whose values have changed, but for which we don't have the new values.
*/
Expand Down

0 comments on commit 029de3d

Please sign in to comment.