remove Dimensions listener on unmount

musaabdullah · Feb 20, 2019 · a359ddc · a359ddc
1 parent 571681d
commit a359ddc
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Swiper.js b/Swiper.js
@@ -85,6 +85,7 @@ class Swiper extends Component {
     this._mounted = false
     this.state.pan.x.removeAllListeners()
     this.state.pan.y.removeAllListeners()
+    Dimensions.removeEventListener('change', this.onDimensionsChange)
   }
 
   getCardStyle = () => {
@@ -110,9 +111,7 @@ class Swiper extends Component {
 
   initializeCardStyle = () => {
     // this.forceUpdate()
-    Dimensions.addEventListener('change', () => {
-      this.forceUpdate()
-    })
+    Dimensions.addEventListener('change', this.onDimensionsChange)
   }
 
   initializePanResponder = () => {
@@ -144,6 +143,10 @@ class Swiper extends Component {
     return { dx, dy }
   }
 
+  onDimensionsChange = () => {
+    this.forceUpdate()
+  }
+
   onPanResponderMove = (event, gestureState) => {
     this.props.onSwiping(this._animatedValueX, this._animatedValueY)