Skip to content

Commit

Permalink
Maintenance: Prefer selector from used variable over hardcoded string.
Browse files Browse the repository at this point in the history
  • Loading branch information
mantas authored and thorsteneckel committed Sep 16, 2019
1 parent 6000b9f commit 89c74ba
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spec/system/ticket/update_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

within(:active_content) do
# update should work now
find('.edit [name=internal_name1]').select('name 2')
find(".edit [name=#{attribute.name}]").select('name 2')
click('.js-attributeBar .js-submit')
expect(page).to have_no_css('.js-submitDropdown .js-submit[disabled]', wait: 2)
end
Expand Down Expand Up @@ -85,7 +85,7 @@
},
})

# refresh browser to get macro accessable
# refresh browser to get macro accessible
refresh

# create a new ticket and attempt to update its state without the required select attribute
Expand Down

0 comments on commit 89c74ba

Please sign in to comment.