Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Next.js and Remix.js examples #213

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Add Next.js and Remix.js examples #213

merged 4 commits into from
Apr 9, 2024

Conversation

decepulis
Copy link
Contributor

@decepulis decepulis commented Apr 4, 2024 •
edited
Loading

  • For Next.js, we just link to vercel/next.js/examples
  • For Remix, I'd like to link to remix-run/examples, but that PR hasn't been accepted yet. (Nor does it look like it'll be accepted any time soon; that repo is kinda a ghost town)
    • So for now, I'm hosting the example here, with a note at the top of the README. If the remix PR is ever accepted, I'll remove the example here and link to the example there just like I do with next.js
    • I also considered just linking to the remix-run/examples PR... So instead of hosting the whole example, we'd just have a link in the readme to this. lmk if you think that would be more consistent

davekiss
davekiss reviewed Apr 8, 2024
View reviewed changes
remixjs-uploader-and-player/README.md Outdated
### Step 1. Create a Remix app with this example

```bash
npx create-remix@latest --template examples/mux-video
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work if the external PR is not accepted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good callout. gotta fix that.

davekiss
davekiss approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@davekiss davekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, only one comment re: cloning the template

@decepulis decepulis merged commit 56b0145 into main Apr 9, 2024
2 of 3 checks passed
@decepulis decepulis deleted the dc/add-framework-examples branch April 9, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davekiss davekiss davekiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decepulis @davekiss