Fix types and add test

muyi-lgh · Nov 26, 2018 · 4752fc7 · 4752fc7
1 parent 5f03443
commit 4752fc7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Writer/SvgWriter.php b/src/Writer/SvgWriter.php
@@ -92,10 +92,10 @@ private function addLogo(SimpleXMLElement $svg, int $imageWidth, int $imageHeigh
         }
 
         $imageDefinition = $svg->addChild('image');
-        $imageDefinition->addAttribute('x', $imageWidth / 2 - $logoWidth / 2);
-        $imageDefinition->addAttribute('y', $imageHeight / 2 - $logoHeight / 2);
-        $imageDefinition->addAttribute('width', $logoWidth);
-        $imageDefinition->addAttribute('height', $logoHeight);
+        $imageDefinition->addAttribute('x', strval($imageWidth / 2 - $logoWidth / 2));
+        $imageDefinition->addAttribute('y', strval($imageHeight / 2 - $logoHeight / 2));
+        $imageDefinition->addAttribute('width', strval($logoWidth));
+        $imageDefinition->addAttribute('height', strval($logoHeight));
         $imageDefinition->addAttribute('preserveAspectRatio', 'none');
         $imageDefinition->addAttribute('xlink:href', 'data:'.$mimeType.';base64,'.base64_encode($imageData));
     }

diff --git a/tests/QrCodeTest.php b/tests/QrCodeTest.php
@@ -60,6 +60,8 @@ public function testFactory(): void
     public function testWriteQrCode(): void
     {
         $qrCode = new QrCode('QR Code');
+        $qrCode->setLogoPath(__DIR__.'/../assets/images/symfony.png');
+        $qrCode->setLogoWidth(100);
 
         $qrCode->setWriterByName('binary');
         $binData = $qrCode->writeString();