Skip to content

Commit

Permalink
MDL-68563 filter_urltolink: enable filter uppon install
Browse files Browse the repository at this point in the history
Every major system that people use these days turns URLs into links automatically.

This filter was turned off by default a decade ago because of performance concerns
that do not apply any more, specially on fresh new installations.

In order to improve user experience on text editing features, the urltolink filter
will be now enabled by default in new installations.
  • Loading branch information
lameze committed May 13, 2020
1 parent 5f95ea8 commit 2a9e5ba
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 2 deletions.
32 changes: 32 additions & 0 deletions filter/urltolink/db/install.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

/**
* URL to link filter post install hook.
*
* @package filter_urltolink
* @copyright 2020 Simey Lameze <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

defined('MOODLE_INTERNAL') || die();

function xmldb_filter_urltolink_install() {
global $CFG;
require_once($CFG->libdir . "/filterlib.php");

filter_set_global_state('urltolink', TEXTFILTER_ON, -1);
}
2 changes: 1 addition & 1 deletion filter/urltolink/settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
$settings->add(new admin_setting_configmulticheckbox('filter_urltolink/formats',
get_string('settingformats', 'filter_urltolink'),
get_string('settingformats_desc', 'filter_urltolink'),
array(FORMAT_MOODLE => 1), format_text_menu()));
[FORMAT_HTML => 1, FORMAT_MARKDOWN => 1, FORMAT_MOODLE => 1], format_text_menu()));

$settings->add(new admin_setting_configcheckbox('filter_urltolink/embedimages',
get_string('embedimages', 'filter_urltolink'),
Expand Down
2 changes: 1 addition & 1 deletion filter/urltolink/version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2019111800; // The current plugin version (Date: YYYYMMDDXX)
$plugin->version = 2020051200; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2019111200; // Requires this Moodle version
$plugin->component = 'filter_urltolink'; // Full name of the plugin (used for diagnostics)

0 comments on commit 2a9e5ba

Please sign in to comment.