MDL-55082 search: Update core areas to return results in time ASC order

mvaraujo · Jun 30, 2016 · 55b6237 · 55b6237
1 parent b8474fe
commit 55b6237
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/course/classes/search/mycourse.php b/course/classes/search/mycourse.php
@@ -49,7 +49,7 @@ class mycourse extends \core_search\area\base {
      */
     public function get_recordset_by_timestamp($modifiedfrom = 0) {
         global $DB;
-        return $DB->get_recordset_select('course', 'timemodified >= ?', array($modifiedfrom));
+        return $DB->get_recordset_select('course', 'timemodified >= ?', array($modifiedfrom), 'timemodified ASC');
     }
 
     /**

diff --git a/mod/glossary/classes/search/entry.php b/mod/glossary/classes/search/entry.php
@@ -53,7 +53,7 @@ public function get_recordset_by_timestamp($modifiedfrom = 0) {
 
         $sql = "SELECT ge.*, g.course FROM {glossary_entries} ge
                   JOIN {glossary} g ON g.id = ge.glossaryid
-                WHERE ge.timemodified >= ?";
+                WHERE ge.timemodified >= ? ORDER BY ge.timemodified ASC";
         return $DB->get_recordset_sql($sql, array($modifiedfrom));
     }
 

diff --git a/mod/survey/classes/search/activity.php b/mod/survey/classes/search/activity.php
@@ -46,7 +46,8 @@ class activity extends \core_search\area\base_activity {
     public function get_recordset_by_timestamp($modifiedfrom = 0) {
         global $DB;
         $select = 'course != ? AND ' . static::MODIFIED_FIELD_NAME . ' >= ?';
-        return $DB->get_recordset_select($this->get_module_name(), $select, array(0, $modifiedfrom));
+        return $DB->get_recordset_select($this->get_module_name(), $select, array(0, $modifiedfrom),
+                static::MODIFIED_FIELD_NAME . ' ASC');
     }
 
 }
diff --git a/search/classes/area/base_activity.php b/search/classes/area/base_activity.php
@@ -62,7 +62,8 @@ abstract class base_activity extends base_mod {
      */
     public function get_recordset_by_timestamp($modifiedfrom = 0) {
         global $DB;
-        return $DB->get_recordset_select($this->get_module_name(), static::MODIFIED_FIELD_NAME . ' >= ?', array($modifiedfrom));
+        return $DB->get_recordset_select($this->get_module_name(), static::MODIFIED_FIELD_NAME . ' >= ?', array($modifiedfrom),
+                static::MODIFIED_FIELD_NAME . ' ASC');
     }
 
     /**

diff --git a/search/tests/fixtures/mock_search_area.php b/search/tests/fixtures/mock_search_area.php
@@ -41,8 +41,8 @@ public function is_enabled() {
     public function get_recordset_by_timestamp($modifiedfrom = 0) {
         global $DB;
 
-        // Filter by capability as we want this quick.
-        return $DB->get_recordset_sql("SELECT * FROM {temp_mock_search_area} WHERE timemodified >= ?", array($modifiedfrom));
+        $sql = "SELECT * FROM {temp_mock_search_area} WHERE timemodified >= ? ORDER BY timemodified ASC";
+        return $DB->get_recordset_sql($sql, array($modifiedfrom));
     }
 
     public function get_document($record, $options = array()) {