MDL-68341 core_table: improve fetch WS php unit coverage

mvaraujo · Apr 21, 2020 · ad176d6 · ad176d6
1 parent 4cf97b7
commit ad176d6
Showing 1 changed file with 21 additions and 1 deletion.
diff --git a/lib/table/tests/external/dynamic/fetch_test.php b/lib/table/tests/external/dynamic/fetch_test.php
@@ -48,6 +48,26 @@ public static function setUpBeforeClass(): void {
         require_once("{$CFG->libdir}/externallib.php");
     }
 
+    /**
+     * Test execute invalid component format.
+     */
+    public function test_execute_invalid_component_format(): void {
+        $this->resetAfterTest();
+
+        $this->expectException(\invalid_parameter_exception::class);
+        fetch::execute("core-user", "participants", "", "email", "4", [], "1");
+    }
+
+    /**
+     * Test execute invalid component.
+     */
+    public function test_execute_invalid_component(): void {
+        $this->resetAfterTest();
+
+        $this->expectException(\UnexpectedValueException::class);
+        fetch::execute("core_users", "participants", "", "email", "4", [], "1");
+    }
+
     /**
      * Test execute invalid handler.
      */
@@ -78,7 +98,7 @@ public function test_execute_invalid_filter(): void {
                 'values' => [(int)$course->id]
             ]
         ];
-        $this->expectException('invalid_parameter_exception');
+        $this->expectException(\invalid_parameter_exception::class);
         $this->expectExceptionMessage("Invalid parameter value detected (filters => Invalid parameter value detected " .
         "(Missing required key in single structure: name): Missing required key in single structure: name");