MDL-58058 competency: Allow unspecified sortorder for new competencies

mvaraujo · Dec 8, 2017 · f250cdb · f250cdb
1 parent 109aa07
commit f250cdb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/competency/classes/competency.php b/competency/classes/competency.php
@@ -76,7 +76,7 @@ protected static function define_properties() {
                 'default' => FORMAT_HTML
             ),
             'sortorder' => array(
-                'default' => null,
+                'default' => 0,
                 'type' => PARAM_INT
             ),
             'parentid' => array(

diff --git a/competency/tests/external_test.php b/competency/tests/external_test.php
@@ -281,8 +281,7 @@ protected function create_competency($number, $frameworkid) {
             'idnumber' => 'idnumber' . $number,
             'description' => 'description' . $number,
             'descriptionformat' => FORMAT_HTML,
-            'competencyframeworkid' => $frameworkid,
-            'sortorder' => 0
+            'competencyframeworkid' => $frameworkid
         );
         $result = external::create_competency($competency);
         return (object) external_api::clean_returnvalue(external::create_competency_returns(), $result);
@@ -294,8 +293,7 @@ protected function update_competency($id, $number) {
             'shortname' => 'shortname' . $number,
             'idnumber' => 'idnumber' . $number,
             'description' => 'description' . $number,
-            'descriptionformat' => FORMAT_HTML,
-            'sortorder' => 0
+            'descriptionformat' => FORMAT_HTML
         );
         $result = external::update_competency($competency);
         return external_api::clean_returnvalue(external::update_competency_returns(), $result);