MDL-39851 javascript: Fixes for filepicker dialogs

Fixes display issues with the filepicker dialogs that were
converted to M.core.dialogue.

Note: These dialogue use table based layouts and the table width is not
counted in the form that it sits in. I have changed the dialogues to have
a wider width but for really small screens this causes horizontal scrolling.

The only solution for that is to rewrite all the filepicker/filemanager dialogs
to use css for layout.

lib/form/filemanager.js

@@ -114,6 +114,7 @@ M.form_filemanager.init = function(Y, options) {
                 headerContent: '<span id="' + labelid +'">' + M.str.moodle.edit + '</span>',
                 bodyContent  : this.selectnode,
                 centered     : true,
+                width        : '480px',
                 modal        : true,
                 visible      : false
             });

repository/filepicker.js

@@ -717,7 +717,7 @@ M.core_filepicker.init = function(Y, options) {
                 node.generateID();
                 this.process_dlg = new M.core.dialogue({
                     draggable    : true,
-                    bodyContent  : this.fpnode,
+                    bodyContent  : node,
                     headerContent: M.str.repository.fileexistsdialogheader,
                     centered     : true,
                     modal        : true,
@@ -1308,6 +1308,7 @@ M.core_filepicker.init = function(Y, options) {
             this.selectui = new M.core.dialogue({
                 headerContent: '<span id="' + fplabel +'">'+M.str.moodle.edit+'</span>',
                 draggable    : true,
+                width        : '450px',
                 bodyContent  : this.selectnode,
                 centered     : true,
                 modal        : true,

theme/base/style/filemanager.css

@@ -239,7 +239,6 @@ a.ygtvspacer:hover {color: transparent;text-decoration: none;}
 /*
  * Select Dialogue (File Picker and File Manager)
  */
-.file-picker.fp-select {width:420px;}
 .fp-select form {padding: 20px 20px 0;}
 .fp-select .fp-select-loading {text-align: center;margin-top: 20px;}
 .fp-select .fp-hr {clear: both;height: 1px; background-color: #FFFFFF;border-bottom: 1px solid #BBBBBB;width: auto; margin: 10px 0;}

theme/bootstrapbase/less/moodle/filemanager.less

@@ -697,9 +697,6 @@ a.ygtvspacer:hover {
     padding-top: 50px;
 }
 // Select Dialogue (File Picker and File Manager)
-.file-picker.fp-select {
-    width: 420px;
-}
 .fp-select form {
     padding: 20px 20px 0;
 }