Simplify http mocks

mweibel · Nov 9, 2017 · 3a248d6 · 3a248d6
1 parent 5d59d29
commit 3a248d6
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 94 deletions.
diff --git a/test/facebook_test.exs b/test/facebook_test.exs
@@ -3,6 +3,8 @@ defmodule FacebookTest do
 
   import Mock
 
+  alias Facebook.GraphMock
+
   @app_id "123"
   @app_secret "456"
   # 19292868552 = facebook for developers page
@@ -22,10 +24,8 @@ defmodule FacebookTest do
   describe "me" do
     test "success", %{id: id, access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.me(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.me(:success) end
       ] do
         assert {:ok, user} = Facebook.me("id,first_name", access_token)
         assert(user["id"] == id)
@@ -35,10 +35,8 @@ defmodule FacebookTest do
 
     test "error", %{invalid_access_token: invalid_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, %{"code" => _,"message" => _,}} = Facebook.me(
           "id,first_name",
@@ -51,10 +49,8 @@ defmodule FacebookTest do
   describe "picture" do
     test "success", %{id: id, access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.picture(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.picture(:success) end
       ] do
         {:ok, %{"data" => picture_data}} = Facebook.picture(
           id,
@@ -68,10 +64,8 @@ defmodule FacebookTest do
 
     test "error", %{id: id, invalid_access_token: invalid_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.picture(id, "small", invalid_access_token)
       end
@@ -81,10 +75,8 @@ defmodule FacebookTest do
   describe "publish" do
     test "feed - success", %{id: id, access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.publish(:success, :feed) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.publish(:success, :feed) end
       ] do
         {:ok, response} = Facebook.publish(
           :feed,
@@ -102,7 +94,7 @@ defmodule FacebookTest do
         request: fn(_method, _url, _headers, _payload, _options) ->
           {:ok, nil, nil, nil}
         end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.publish(
           :feed,
@@ -116,10 +108,8 @@ defmodule FacebookTest do
 
     test "photo - success", %{id: id, access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.publish(:success, :image) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.publish(:success, :image) end
       ] do
         file_path = "test/assets/sample_image.png"
         assert {:ok, %{"id" => _, "post_id" => _}} = Facebook.publish(
@@ -137,7 +127,7 @@ defmodule FacebookTest do
         request: fn(_method, _url, _headers, _payload, _options) ->
           {:ok, nil, nil, nil}
         end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        body: fn(_) -> GraphMock.error() end
       ] do
         file_path = "test/assets/sample_image.png"
         assert {:error, _} = Facebook.publish(
@@ -152,10 +142,8 @@ defmodule FacebookTest do
 
     test "video - success", %{id: id, access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.publish(:success, :image) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.publish(:success, :image) end
       ] do
         file_path = "test/assets/sample_video.mpg"
         assert {:ok, response} = Facebook.publish(
@@ -174,7 +162,7 @@ defmodule FacebookTest do
         request: fn(_method, _url, _headers, _payload, _options) ->
           {:ok, nil, nil, nil}
         end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        body: fn(_) -> GraphMock.error() end
       ] do
         file_path = "test/assets/sample_image.png"
         assert {:error, _} = Facebook.publish(
@@ -191,10 +179,8 @@ defmodule FacebookTest do
   describe "my_likes" do
     test "success", %{access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.my_likes(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.my_likes(:success) end
       ] do
         {:ok, likes_data} = Facebook.my_likes(access_token)
 
@@ -204,10 +190,8 @@ defmodule FacebookTest do
 
     test "error", %{invalid_access_token: invalid_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.my_likes(invalid_access_token)
       end
@@ -217,10 +201,8 @@ defmodule FacebookTest do
   describe "permissions" do
     test "success", %{id: id, access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.permissions(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.permissions(:success) end
       ] do
         assert {:ok, %{"data" => data}} = Facebook.permissions(id, access_token)
 
@@ -232,10 +214,8 @@ defmodule FacebookTest do
 
     test "error", %{id: id, invalid_access_token: invalid_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.permissions(id, invalid_access_token)
       end
@@ -245,10 +225,8 @@ defmodule FacebookTest do
   describe "fan_count" do
     test "success", %{app_access_token: app_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.page(:success, :fan_count) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.page(:success, :fan_count) end
       ] do
         assert {:ok, %{"fan_count" => _}} = Facebook.fan_count(
           @page_id,
@@ -259,10 +237,8 @@ defmodule FacebookTest do
 
     test "error", %{invalid_access_token: invalid_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.fan_count(@page_id, invalid_access_token)
       end
@@ -272,10 +248,8 @@ defmodule FacebookTest do
   describe "page" do
     test "success", %{app_access_token: app_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.page(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.page(:success) end
       ] do
         assert {:ok, %{
           "name" => name,
@@ -289,10 +263,8 @@ defmodule FacebookTest do
 
     test "error", %{invalid_access_token: invalid_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.page(@page_id, invalid_access_token)
       end
@@ -302,10 +274,8 @@ defmodule FacebookTest do
   describe "page with fields" do
     test "success", %{app_access_token: app_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.page(:success, :with_fields) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.page(:success, :with_fields) end
       ] do
         assert {:ok, %{
           "id" => id,
@@ -322,7 +292,7 @@ defmodule FacebookTest do
         request: fn(_method, _url, _headers, _payload, _options) ->
           {:ok, nil, nil, nil}
         end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.page(
           @page_id,
@@ -336,10 +306,8 @@ defmodule FacebookTest do
   describe "page feed" do
     test "success", %{app_access_token: app_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.page(:success, :feed) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.page(:success, :feed) end
       ] do
         assert {:ok, %{"data" => [data | _]}} = Facebook.page_feed(
           :feed,
@@ -362,7 +330,7 @@ defmodule FacebookTest do
         request: fn(_method, _url, _headers, _payload, _options) ->
           {:ok, nil, nil, nil}
         end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.page_feed(
           :feed,
@@ -377,10 +345,8 @@ defmodule FacebookTest do
   describe "object count" do
     test "success", %{access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.object_count(:success, :likes) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.object_count(:success, :likes) end
       ] do
         assert {:ok, 10} = Facebook.object_count(
           :likes,
@@ -394,10 +360,8 @@ defmodule FacebookTest do
   describe "object reaction count" do
     test "success", %{access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.object_count(:success, :likes) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.object_count(:success, :likes) end
       ] do
         assert {:ok, 10} = Facebook.object_count(
           :reaction,
@@ -412,10 +376,8 @@ defmodule FacebookTest do
   describe "object count all" do
     test "success", %{access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.object_count_all(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.object_count_all(:success) end
       ] do
         assert {:ok, %{"haha" => haha, "love" => love}} = Facebook.object_count_all(
           "#{@test_page_id}_629967087187379",
@@ -431,10 +393,8 @@ defmodule FacebookTest do
   describe "long lived access token" do
     test "success", %{access_token: access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.long_lived_access_token(:success) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.long_lived_access_token(:success) end
       ] do
         assert {:ok, %{
           "access_token" => access_token,
@@ -457,7 +417,7 @@ defmodule FacebookTest do
         request: fn(_method, _url, _headers, _payload, _options) ->
           {:ok, nil, nil, nil}
         end,
-        body: fn(_) -> Facebook.GraphMock.error() end
+        body: fn(_) -> GraphMock.error() end
       ] do
         assert {:error, _} = Facebook.long_lived_access_token(
           @app_id,
@@ -471,10 +431,8 @@ defmodule FacebookTest do
   describe "new stream" do
     test "success", %{app_access_token: app_access_token} do
       with_mock :hackney, [
-        request: fn(_method, _url, _headers, _payload, _options) ->
-          {:ok, nil, nil, nil}
-        end,
-        body: fn(_) -> Facebook.GraphMock.page(:success, :feed) end
+        request: GraphMock.request,
+        body: fn(_) -> GraphMock.page(:success, :feed) end
       ] do
         posts = Facebook.page_feed(
           :feed,

diff --git a/test/graph_mock.ex b/test/graph_mock.ex
@@ -101,4 +101,10 @@ defmodule Facebook.GraphMock do
       "id": "120762398683628",
     })
   end
+
+  def request do
+    fn(_method, _url, _headers, _payload, _options) ->
+      {:ok, nil, nil, nil}
+    end
+  end
 end