Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Larger Files with Asset Data Type #15

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Support Larger Files with Asset Data Type #15

wants to merge 5 commits into from

Conversation

ezfe
Copy link

@ezfe ezfe commented Feb 20, 2019

I put this PR together to show how this would work, and did a quick test to make sure it worked. This pull request changes the data type from Bytes to Asset, and creates a new CKAsset when uploading.

Note: This does not convert existing records, so I changed the field name from data to asset to keep compatibility.

screen shot 2019-02-20 at 12 23 23 am

@mxcl mxcl force-pushed the master branch 2 times, most recently from a9ce3ed to 9437c54 Compare February 20, 2019 15:18
@mxcl
Copy link
Owner

mxcl commented Feb 20, 2019

I am actually reluctant to change this before someone presents rationale for it.

The tool is not designed for large files, we don’t diff for example, so everything is uploaded/downloaded every time a change happens.

@ezfe
Copy link
Author

ezfe commented Feb 20, 2019

Of course, that makes sense, I didn't put much work into this and I just wanted to see your thoughts. Feel free to close this PR at your own discretion.

@mxcl mxcl force-pushed the master branch 2 times, most recently from 2ff6b75 to 4eed844 Compare March 6, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants