Skip to content

Commit

Permalink
chore: update placeholder tests and functional ui todo
Browse files Browse the repository at this point in the history
  • Loading branch information
ashleysimpson committed Jan 31, 2019
1 parent 9f39102 commit 0ed5bc7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
22 changes: 7 additions & 15 deletions tests/client/components/carousel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,18 +139,6 @@ describe('Carousel component', () => {
});
});

// start on first slide and allow the autoplay to advance to the second slide
it.skip('should display the second slide after waiting the timeout duration with direction forward', () => {});

// start on the second slide and allow autoplay to advanced to the first slide
it.skip('should display the first slide after waiting the timeout duration with direction backward', () => {});

it.skip('should not allow the autoplay feature to advance on hover', () => {});

it.skip('should allow the autoplay feature to advance on hover when hover pause false', () => {});

it.skip('should show the first slide twice when looping is enabled with autoplay', () => {});

it('should reset autoplay when switching slide without autoplayHoverPause', done => {
const wrapper = mount(Carousel, {
propsData: {
Expand Down Expand Up @@ -207,13 +195,17 @@ describe('Carousel component', () => {

it.skip('should set easing to the custom easing supplied', () => {});

// TODO: Should we be testing for valid CSS transition easing like the README suggests?
// TODO: Add tests for valid CSS transition easing
});

describe('Dynamic slide count', () => {
it.skip('should match the stored snapshot if a new slide is added dynamically', () => {});

it.skip('should match the stored snapshot if a slide is removed dynamically', () => {});

it.skip('should have the correct tabIndex if a new slide is added dynamically', () => {});

it.skip('should have the correct tabIndex if a slide is removed dynamically', () => {});
});

describe('Loop functionality', () => {
Expand Down Expand Up @@ -339,7 +331,7 @@ describe('Carousel component', () => {
it.skip('should only have one page when number of slides is less than slides per page', () => {});
});

describe('Resistance co-efficient', () => {
describe('Carousel resistance co-efficient pull effect', () => {
it.skip('should have the resistanceCoef set to 20 by default', () => {});

it.skip('should set the resistanceCoef to 30', () => {});
Expand Down Expand Up @@ -428,7 +420,7 @@ describe('Carousel component', () => {
describe('Events', () => {
it.skip('should emit a pageChange event with the page number on page change', () => {});

it.skip('should emit a slideClick event with the object?? blah on slide click', () => {});
it.skip('should emit a slideClick event with a dataset object on slide click', () => {});

it.skip('should emit a transitionEnd event on transition end', () => {});
});
Expand Down
11 changes: 11 additions & 0 deletions tests/functional/TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Function UI Tests

This is a document to keep track of the functional ui tests we want to implement. Please add to this file as you discover new UI tests you would like to add.

## autoplay

* display the second slide after waiting the timeout duration with direction forward
* display the first slide after waiting the timeout duration with direction backward
* no autoplay advance on hover
* autoplay advance on hover when hover pause false
* loop to the first slide when looping is enabled

0 comments on commit 0ed5bc7

Please sign in to comment.