Fix bug for scrapyd v1.5.0

[my8100]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build e216c1fa-3f0d-4af3-b5a9-93e3c04fcdc8

Details

• 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.06%) to 85.873%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
scrapydweb/views/dashboard/jobs.py	1	2	50.0%

Files with Coverage Reduction	New Missed Lines	%
scrapydweb/views/api.py	1	78.89%
scrapydweb/views/dashboard/jobs.py	2	90.91%

Totals
Change from base Build 97acaa42-fd67-4b1b-8515-71c4daa9cd22:	0.06%
Covered Lines:	3471
Relevant Lines:	4042

---

💛 - Coveralls

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.87%. Comparing base (19d8073) to head (03d64fb).

Files with missing lines	Patch %	Lines
scrapydweb/views/dashboard/jobs.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   85.81%   85.87%   +0.05%     
==========================================
  Files          34       34              
  Lines        4040     4042       +2     
==========================================
+ Hits         3467     3471       +4     
+ Misses        573      571       -2     

Files with missing lines	Coverage Δ
scrapydweb/utils/poll.py	81.54% <ø> (ø)
scrapydweb/vars.py	92.85% <100.00%> (ø)
scrapydweb/views/dashboard/jobs.py	92.16% <50.00%> (+0.62%)	⬆️

... and 2 files with indirect coverage changes

[pep8speaks]

Hello @my8100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file tests/utils.py:

Line 123:9: F841 local variable 'err' is assigned to but never used

Comment last updated at 2025-01-12 10:25:08 UTC