Hotfix/ability to create invalid enums #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity-to-create-invalid-enums Conflicts: src/Enum.php
| /** | ||
| * @see https://github.com/myclabs/php-enum/issues/9 | ||
| */ | ||
| $this->assertEquals(EnumFixture::PROBLEMATIC_NUMBER, EnumFixture::search(1)); |
There was a problem hiding this comment.
Here we search for 1 and we check it returns PROBLEMATIC_NUMBER whose value is 0, is that normal?
There was a problem hiding this comment.
No, it's not normal. I've just added that so that I could reference it in another bug ticket, since search() method is also not type safe. I'll fix that soon.
There was a problem hiding this comment.
OK so we leave it that way for now but you are planning to fix it?
|
Very good stuff! |
| [EnumFixture::FOO, new EnumFixture(EnumFixture::FOO)], | ||
| [EnumFixture::BAR, new EnumFixture(EnumFixture::BAR)], | ||
| [(string) EnumFixture::NUMBER, new EnumFixture(EnumFixture::NUMBER)], | ||
| ]; |
There was a problem hiding this comment.
We have to keep BC with PHP 5.3 (yeah I know -_-)
Tests are failing because of that.
mnapoli
added a commit
that referenced
this pull request
Feb 10, 2015
…-enums Hotfix/ability to create invalid enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
@mnapoli please have a look.