Skip to content

Commit

Permalink
all: use HTTPS for iana.org links
Browse files Browse the repository at this point in the history
iana.org, www.iana.org and data.iana.org all present a valid TLS
certificate, so let's use it when fetching data or linking to
resources to avoid errors in transit.

Change-Id: Ib3ce7c19789c4e9d982a776b61d8380ddc63194d
Reviewed-on: https://go-review.googlesource.com/89416
Reviewed-by: Brad Fitzpatrick <[email protected]>
  • Loading branch information
kevinburke authored and bradfitz committed Feb 13, 2018
1 parent c10e614 commit 5158aab
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 15 deletions.
2 changes: 1 addition & 1 deletion lib/time/README
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ the code and data maintained as part of the IANA Time Zone Database.
The IANA asserts that the database is in the public domain.

For more information, see
http://www.iana.org/time-zones
https://www.iana.org/time-zones
ftp://ftp.iana.org/tz/code/tz-link.htm
http://tools.ietf.org/html/rfc6557

Expand Down
9 changes: 4 additions & 5 deletions lib/time/update.bash
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# This script rebuilds the time zone files using files
# downloaded from the ICANN/IANA distribution.
# Consult http://www.iana.org/time-zones for the latest versions.
# Consult https://www.iana.org/time-zones for the latest versions.

# Versions to use.
CODE=2017c
Expand All @@ -16,8 +16,8 @@ rm -rf work
mkdir work
cd work
mkdir zoneinfo
curl -L -O http://www.iana.org/time-zones/repository/releases/tzcode$CODE.tar.gz
curl -L -O http://www.iana.org/time-zones/repository/releases/tzdata$DATA.tar.gz
curl -L -O https://www.iana.org/time-zones/repository/releases/tzcode$CODE.tar.gz
curl -L -O https://www.iana.org/time-zones/repository/releases/tzdata$DATA.tar.gz
tar xzf tzcode$CODE.tar.gz
tar xzf tzdata$DATA.tar.gz

Expand All @@ -42,10 +42,9 @@ zip -0 -r ../../zoneinfo.zip *
cd ../..

echo
if [ "$1" = "-work" ]; then
if [ "$1" = "-work" ]; then
echo Left workspace behind in work/.
else
rm -rf work
fi
echo New time zone files in zoneinfo.zip.

2 changes: 1 addition & 1 deletion misc/nacl/testdata/mime.types
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# content languages and encodings, so choose them carefully.
#
# Internet media types should be registered as described in RFC 4288.
# The registry is at <http://www.iana.org/assignments/media-types/>.
# The registry is at <https://www.iana.org/assignments/media-types/>.
#
# MIME type (lowercased) Extensions
# ============================================ ==========
Expand Down
2 changes: 1 addition & 1 deletion src/crypto/tls/cipher_suites.go
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ func mutualCipherSuite(have []uint16, want uint16) *cipherSuite {
// A list of cipher suite IDs that are, or have been, implemented by this
// package.
//
// Taken from http://www.iana.org/assignments/tls-parameters/tls-parameters.xml
// Taken from https://www.iana.org/assignments/tls-parameters/tls-parameters.xml
const (
TLS_RSA_WITH_RC4_128_SHA uint16 = 0x0005
TLS_RSA_WITH_3DES_EDE_CBC_SHA uint16 = 0x000a
Expand Down
4 changes: 2 additions & 2 deletions src/crypto/tls/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const (
)

// CurveID is the type of a TLS identifier for an elliptic curve. See
// http://www.iana.org/assignments/tls-parameters/tls-parameters.xml#tls-parameters-8
// https://www.iana.org/assignments/tls-parameters/tls-parameters.xml#tls-parameters-8
type CurveID uint16

const (
Expand All @@ -102,7 +102,7 @@ const (
)

// TLS Elliptic Curve Point Formats
// http://www.iana.org/assignments/tls-parameters/tls-parameters.xml#tls-parameters-9
// https://www.iana.org/assignments/tls-parameters/tls-parameters.xml#tls-parameters-9
const (
pointFormatUncompressed uint8 = 0
)
Expand Down
2 changes: 1 addition & 1 deletion src/net/http/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
package http

// HTTP status codes as registered with IANA.
// See: http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
// See: https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
const (
StatusContinue = 100 // RFC 7231, 6.2.1
StatusSwitchingProtocols = 101 // RFC 7231, 6.2.2
Expand Down
2 changes: 1 addition & 1 deletion src/net/lookup.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
// names and numbers for platforms that don't have a complete list of
// protocol numbers.
//
// See http://www.iana.org/assignments/protocol-numbers
// See https://www.iana.org/assignments/protocol-numbers
//
// On Unix, this map is augmented by readProtocols via lookupProtocol.
var protocols = map[string]int{
Expand Down
4 changes: 2 additions & 2 deletions src/net/lookup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -664,10 +664,10 @@ func srvString(srvs []*SRV) string {
}

func TestLookupPort(t *testing.T) {
// See http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml
// See https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml
//
// Please be careful about adding new test cases.
// There are platforms having incomplete mappings for
// There are platforms which have incomplete mappings for
// restricted resource access and security reasons.
type test struct {
network string
Expand Down
2 changes: 1 addition & 1 deletion src/time/zoneinfo.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ func (l *Location) lookup(sec int64) (name string, offset int, isDST bool, start
// times.
//
// The reference implementation in localtime.c from
// http://www.iana.org/time-zones/repository/releases/tzcode2013g.tar.gz
// https://www.iana.org/time-zones/repository/releases/tzcode2013g.tar.gz
// implements the following algorithm for these cases:
// 1) If the first zone is unused by the transitions, use it.
// 2) Otherwise, if there are transition times, and the first
Expand Down

0 comments on commit 5158aab

Please sign in to comment.