Fix the warning added to Python 3.8: SyntaxWarning: "is" with a liter…

…al. Did you mean "=="?

examples/GetADUsers.py

@@ -226,7 +226,7 @@ def run(self):
         password = password + '@' + address.rpartition('@')[0]
         address = address.rpartition('@')[2]
 
-    if domain is '':
+    if domain == '':
         logging.critical('Domain should be specified!')
         sys.exit(1)
 

examples/GetNPUsers.py

@@ -410,7 +410,7 @@ def request_multiple_TGTs(self, usernames):
         password = password + '@' + address.rpartition('@')[0]
         address = address.rpartition('@')[2]
 
-    if domain is '':
+    if domain == '':
         logging.critical('Domain should be specified!')
         sys.exit(1)
 

examples/GetUserSPNs.py

@@ -435,7 +435,7 @@ def run(self):
         password = password + '@' + address.rpartition('@')[0]
         address = address.rpartition('@')[2]
 
-    if userDomain is '':
+    if userDomain == '':
         logging.critical('userDomain should be specified!')
         sys.exit(1)
 

examples/addcomputer.py

@@ -620,7 +620,7 @@ def run(self):
         '')
 
     try:
-        if domain is None or domain is '':
+        if domain is None or domain == '':
             logging.critical('Domain should be specified!')
             sys.exit(1)
 

examples/goldenPac.py

@@ -936,7 +936,7 @@ def exploit(self):
                         # Windows XP). So, if that's the case we'll force using RC4 by converting
                         # the password to lm/nt hashes and hope for the best. If that's already
                         # done, byebye.
-                        if self.__lmhash is '' and self.__nthash is '':
+                        if self.__lmhash == '' and self.__nthash == '':
                             from impacket.ntlm import compute_lmhash, compute_nthash
                             self.__lmhash = compute_lmhash(self.__password)
                             self.__nthash = compute_nthash(self.__password)
@@ -991,7 +991,7 @@ def exploit(self):
                         # Windows XP). So, if that's the case we'll force using RC4 by converting
                         # the password to lm/nt hashes and hope for the best. If that's already
                         # done, byebye.
-                        if self.__lmhash is '' and self.__nthash is '':
+                        if self.__lmhash == '' and self.__nthash == '':
                             from impacket.ntlm import compute_lmhash, compute_nthash
                             self.__lmhash = compute_lmhash(self.__password)
                             self.__nthash = compute_nthash(self.__password)
@@ -1116,7 +1116,7 @@ def exploit(self):
         password = password + '@' + address.rpartition('@')[0]
         address = address.rpartition('@')[2]
 
-    if domain is '':
+    if domain == '':
         logging.critical('Domain should be specified!')
         sys.exit(1)
 

examples/ntfs-read.py

@@ -497,7 +497,7 @@ def read(self,offset,length):
         if offset % self.ClusterSize:
             # Read the whole VCN
             bufTemp = self.readVCN(vcnToStart, 1)
-            if bufTemp is b'':
+            if bufTemp == b'':
                 # Something went wrong
                 return None
             buf = bufTemp[offset % self.ClusterSize:]
@@ -513,7 +513,7 @@ def read(self,offset,length):
         if curLength // self.ClusterSize:
             # Yep.. so let's read full clusters
             bufTemp = self.readVCN(vcnToStart, curLength // self.ClusterSize)
-            if bufTemp is b'':
+            if bufTemp == b'':
                 # Something went wrong
                 return None
             if len(bufTemp) > curLength:

examples/raiseChild.py

@@ -1103,7 +1103,7 @@ def raiseUp(self, childName, childCreds, parentName):
                     # Windows XP). So, if that's the case we'll force using RC4 by converting
                     # the password to lm/nt hashes and hope for the best. If that's already
                     # done, byebye.
-                    if childCreds['lmhash'] is '' and childCreds['nthash'] is '':
+                    if childCreds['lmhash'] == '' and childCreds['nthash'] == '':
                         from impacket.ntlm import compute_lmhash, compute_nthash
                         childCreds['lmhash'] = compute_lmhash(childCreds['password'])
                         childCreds['nthash'] = compute_nthash(childCreds['password'])
@@ -1144,7 +1144,7 @@ def raiseUp(self, childName, childCreds, parentName):
                     # Windows XP). So, if that's the case we'll force using RC4 by converting
                     # the password to lm/nt hashes and hope for the best. If that's already
                     # done, byebye.
-                    if childCreds['lmhash'] is '' and childCreds['nthash'] is '':
+                    if childCreds['lmhash'] == '' and childCreds['nthash'] == '':
                         from impacket.ntlm import compute_lmhash, compute_nthash
                         childCreds['lmhash'] = compute_lmhash(childCreds['password'])
                         childCreds['nthash'] = compute_nthash(childCreds['password'])
@@ -1271,7 +1271,7 @@ def exploit(self):
     else:
         logging.getLogger().setLevel(logging.INFO)
 
-    if domain is '':
+    if domain == '':
         logging.critical('Domain should be specified!')
         sys.exit(1)
 

impacket/dcerpc/v5/dcom/wmi.py

@@ -2409,7 +2409,7 @@ def marshalMe(self):
                 if itemValue is None:
                     ndTable |= 3 << (2*i)
             else:
-                if itemValue is '':
+                if itemValue == '':
                     ndTable |= 1 << (2*i)
                     valueTable += pack('<L', 0)
                 else:

impacket/dcerpc/v5/ndr.py

@@ -1333,7 +1333,7 @@ def getData(self, soFar = 0):
             data += b'\xbd'*pad
             soFar += pad
 
-        if self.structure is ():
+        if self.structure == ():
             return data
 
         for fieldName, fieldTypeOrClass in self.structure:
@@ -1420,7 +1420,7 @@ def fromString(self, data, soFar = 0 ):
             data = data[pad:]
             soFar += pad
 
-        if self.structure is ():
+        if self.structure == ():
             return soFar-soFar0
 
         for fieldName, fieldTypeOrClass in self.structure:

impacket/krb5/kerberosv5.py

@@ -166,7 +166,7 @@ def getKerberosTGT(clientName, password, domain, lmhash, nthash, aesKey='', kdcH
         r = sendReceive(message, domain, kdcHost)
     except KerberosError as e:
         if e.getErrorCode() == constants.ErrorCodes.KDC_ERR_ETYPE_NOSUPP.value:
-            if supportedCiphers[0] in (constants.EncryptionTypes.aes128_cts_hmac_sha1_96.value, constants.EncryptionTypes.aes256_cts_hmac_sha1_96.value) and aesKey is '':
+            if supportedCiphers[0] in (constants.EncryptionTypes.aes128_cts_hmac_sha1_96.value, constants.EncryptionTypes.aes256_cts_hmac_sha1_96.value) and aesKey == '':
                 supportedCiphers = (int(constants.EncryptionTypes.rc4_hmac.value),)
                 seq_set_iter(reqBody, 'etype', supportedCiphers)
                 message = encoder.encode(asReq)
@@ -299,7 +299,7 @@ def getKerberosTGT(clientName, password, domain, lmhash, nthash, aesKey='', kdcH
             tgt = sendReceive(encoder.encode(asReq), domain, kdcHost)
         except Exception as e:
             if str(e).find('KDC_ERR_ETYPE_NOSUPP') >= 0:
-                if lmhash is b'' and nthash is b'' and (aesKey is b'' or aesKey is None):
+                if lmhash == b'' and nthash == b'' and (aesKey == b'' or aesKey is None):
                     from impacket.ntlm import compute_lmhash, compute_nthash
                     lmhash = compute_lmhash(password)
                     nthash = compute_nthash(password)
@@ -576,7 +576,7 @@ def getKerberosType1(username, password, domain, lmhash, nthash, aesKey='', TGT
                         # So, if that's the case we'll force using RC4 by converting
                         # the password to lm/nt hashes and hope for the best. If that's already
                         # done, byebye.
-                        if lmhash is b'' and nthash is b'' and (aesKey is b'' or aesKey is None) and TGT is None and TGS is None:
+                        if lmhash == b'' and nthash == b'' and (aesKey == b'' or aesKey is None) and TGT is None and TGS is None:
                             from impacket.ntlm import compute_lmhash, compute_nthash
                             LOG.debug('Got KDC_ERR_ETYPE_NOSUPP, fallback to RC4')
                             lmhash = compute_lmhash(password)
@@ -604,7 +604,7 @@ def getKerberosType1(username, password, domain, lmhash, nthash, aesKey='', TGT
                     # So, if that's the case we'll force using RC4 by converting
                     # the password to lm/nt hashes and hope for the best. If that's already
                     # done, byebye.
-                    if lmhash is b'' and nthash is b'' and (aesKey is b'' or aesKey is None) and TGT is None and TGS is None:
+                    if lmhash == b'' and nthash == b'' and (aesKey == b'' or aesKey is None) and TGT is None and TGS is None:
                         from impacket.ntlm import compute_lmhash, compute_nthash
                         LOG.debug('Got KDC_ERR_ETYPE_NOSUPP, fallback to RC4')
                         lmhash = compute_lmhash(password)

impacket/smbconnection.py

@@ -349,7 +349,7 @@ def kerberosLogin(self, user, password, domain='', lmhash='', nthash='', aesKey=
                     # So, if that's the case we'll force using RC4 by converting
                     # the password to lm/nt hashes and hope for the best. If that's already
                     # done, byebye.
-                    if lmhash is '' and nthash is '' and (aesKey is '' or aesKey is None) and TGT is None and TGS is None:
+                    if lmhash == '' and nthash == '' and (aesKey == '' or aesKey is None) and TGT is None and TGS is None:
                         lmhash = compute_lmhash(password)
                         nthash = compute_nthash(password) 
                     else:

impacket/tds.py

@@ -775,7 +775,7 @@ def kerberosLogin(self, database, username, password='', domain='', hashes=None,
                             # So, if that's the case we'll force using RC4 by converting
                             # the password to lm/nt hashes and hope for the best. If that's already
                             # done, byebye.
-                            if lmhash is '' and nthash is '' and (aesKey is '' or aesKey is None) and TGT is None and TGS is None:
+                            if lmhash == '' and nthash == '' and (aesKey == '' or aesKey is None) and TGT is None and TGS is None:
                                 from impacket.ntlm import compute_lmhash, compute_nthash
                                 LOG.debug('Got KDC_ERR_ETYPE_NOSUPP, fallback to RC4')
                                 lmhash = compute_lmhash(password)
@@ -810,7 +810,7 @@ def kerberosLogin(self, database, username, password='', domain='', hashes=None,
                         # So, if that's the case we'll force using RC4 by converting
                         # the password to lm/nt hashes and hope for the best. If that's already
                         # done, byebye.
-                        if lmhash is '' and nthash is '' and (aesKey is '' or aesKey is None) and TGT is None and TGS is None:
+                        if lmhash == '' and nthash == '' and (aesKey == '' or aesKey is None) and TGT is None and TGS is None:
                             from impacket.ntlm import compute_lmhash, compute_nthash
                             LOG.debug('Got KDC_ERR_ETYPE_NOSUPP, fallback to RC4')
                             lmhash = compute_lmhash(password)

tests/SMB_RPC/test_drsuapi.py

@@ -326,7 +326,7 @@ def test_DRSGetNCChanges(self):
         #        thisObject.dump()
         #        print thisObject['Entinf']['pName']['StringName']
         #        thisObject = nextObject
-        #        if nextObject is '':
+        #        if nextObject == '':
         #            done = True
         #    request['pmsgIn']['V8']['uuidInvocIdSrc'] = resp['pmsgOut']['V6']['uuidInvocIdSrc']
         #    request['pmsgIn']['V8']['usnvecFrom'] = resp['pmsgOut']['V6']['usnvecTo']
@@ -345,7 +345,7 @@ def getMoreData(self, dce, request, resp):
                 #print '\n'
                 #print thisObject['Entinf']['pName']['StringName']
             #    thisObject = nextObject
-            #    if nextObject is '':
+            #    if nextObject == '':
             #        done = True
 
             request['pmsgIn']['V10']['uuidInvocIdSrc'] = resp['pmsgOut']['V6']
@@ -446,7 +446,7 @@ def test_DRSGetNCChanges2(self):
         #        #print '\n'
         #        #print thisObject['Entinf']['pName']['StringName']
         #        thisObject = nextObject
-        #        if nextObject is '':
+        #        if nextObject == '':
         #            done = True
 #
 #            print "B"*80