Skip to content

Commit

Permalink
Update normalize.css and change how we include it (thoughtbot#882)
Browse files Browse the repository at this point in the history
* Update normalize.css and change how we include it

- Update normalize.css to v7.0.0.
- Include normalize.css as raw CSS, instead of through RubyGems because
  the normalize-rails gem has fallen much behing the release cycle of
  normalize.css.

* Ignore reset directory from scss-lint

* Put normalize.css in vendor directory
  • Loading branch information
tysongach authored and nickcharlton committed May 19, 2017
1 parent 03b2ad4 commit ec6491a
Show file tree
Hide file tree
Showing 6 changed files with 450 additions and 5 deletions.
2 changes: 2 additions & 0 deletions .scss-lint.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
scss_files: "app/assets/stylesheets/administrate/**/*.scss"

exclude: "app/assets/stylesheets/administrate/reset/**"

severity: warning

linters:
Expand Down
2 changes: 0 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ PATH
jquery-rails (>= 4.0)
kaminari (>= 1.0)
momentjs-rails (~> 2.8)
normalize-rails (>= 3.0)
sass-rails (~> 5.0)
selectize-rails (~> 0.6)

Expand Down Expand Up @@ -149,7 +148,6 @@ GEM
multipart-post (2.0.0)
nokogiri (1.7.2)
mini_portile2 (~> 2.1.0)
normalize-rails (4.1.1)
parser (2.4.0.0)
ast (~> 2.2)
pg (0.20.0)
Expand Down
1 change: 0 additions & 1 deletion administrate.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Gem::Specification.new do |s|
s.add_dependency "jquery-rails", ">= 4.0"
s.add_dependency "kaminari", ">= 1.0"
s.add_dependency "momentjs-rails", "~> 2.8"
s.add_dependency "normalize-rails", ">= 3.0"
s.add_dependency "sass-rails", "~> 5.0"
s.add_dependency "selectize-rails", "~> 0.6"

Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/administrate/application.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@charset "utf-8";

@import "normalize-rails";
@import "normalize";

@import "selectize";
@import "datetime_picker";
Expand Down
1 change: 0 additions & 1 deletion lib/administrate/engine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
require "jquery-rails"
require "kaminari"
require "momentjs-rails"
require "normalize-rails"
require "sass-rails"
require "selectize-rails"
require "sprockets/railtie"
Expand Down
Loading

0 comments on commit ec6491a

Please sign in to comment.