Skip to content

Commit

Permalink
Refactoring text_editing.dart (flutter#12479)
Browse files Browse the repository at this point in the history
* Refacting text_editing.dart to use EditingState more efficiently and removing unused/unimplemented code.

* Addressing PR comments. Comment changes. Removing unused methods. Method renaming.

* commiting text_editing_test.dart changes.
  • Loading branch information
nturgut authored Sep 30, 2019
1 parent e068591 commit a3a991a
Show file tree
Hide file tree
Showing 3 changed files with 131 additions and 279 deletions.
1 change: 0 additions & 1 deletion lib/web_ui/lib/src/engine/semantics/text_field.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class TextField extends RoleManager {
persistentTextEditingElement = PersistentTextEditingElement(
textEditing,
editableDomElement,
onDomElementSwap: _setupDomElement,
);
_setupDomElement();
}
Expand Down
Loading

0 comments on commit a3a991a

Please sign in to comment.