Set poll interval for filebased dynamic config if not set (cadence-wo…

…rkflow#5160) * Set poll interval for filebased dynamic config if not set * update unit test
naheedmk · Mar 16, 2023 · 1304570 · 1304570
1 parent 42a14b1
commit 1304570
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/common/dynamicconfig/file_based_client.go b/common/dynamicconfig/file_based_client.go
@@ -367,8 +367,10 @@ func validateConfig(config *FileBasedClientConfig) error {
 	if _, err := os.Stat(config.Filepath); err != nil {
 		return fmt.Errorf("error checking dynamic config file at path %s, error: %v", config.Filepath, err)
 	}
+
+	// check if poll interval needs to be adjusted
 	if config.PollInterval < minPollInterval {
-		return fmt.Errorf("poll interval should be at least %v", minPollInterval)
+		config.PollInterval = minPollInterval
 	}
 	return nil
 }
diff --git a/common/dynamicconfig/file_based_client_test.go b/common/dynamicconfig/file_based_client_test.go
@@ -226,11 +226,14 @@ func (s *fileBasedClientSuite) TestValidateConfig_FileNotExist() {
 }
 
 func (s *fileBasedClientSuite) TestValidateConfig_ShortPollInterval() {
-	_, err := NewFileBasedClient(&FileBasedClientConfig{
+	cfg := &FileBasedClientConfig{
 		Filepath:     "config/testConfig.yaml",
 		PollInterval: time.Second,
-	}, nil, nil)
-	s.Error(err)
+	}
+	_, err := NewFileBasedClient(cfg, log.NewNoop(), nil)
+	s.NoError(err)
+	s.Equal(minPollInterval, cfg.PollInterval, "fallback to default poll interval")
+
 }
 
 func (s *fileBasedClientSuite) TestMatch() {