Merge pull request facebook#1190 from spicyj/custom-set-null

Remove custom attrs properly when setting to null
naholyr · Apr 12, 2014 · f4f6b05 · f4f6b05
2 parents b067556 + c3cfcf0
commit f4f6b05
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/browser/ui/dom/DOMPropertyOperations.js b/src/browser/ui/dom/DOMPropertyOperations.js
@@ -137,7 +137,7 @@ var DOMPropertyOperations = {
       }
     } else if (DOMProperty.isCustomAttribute(name)) {
       if (value == null) {
-        node.removeAttribute(DOMProperty.getAttributeName[name]);
+        node.removeAttribute(name);
       } else {
         node.setAttribute(name, '' + value);
       }

diff --git a/src/browser/ui/dom/__tests__/DOMPropertyOperations-test.js b/src/browser/ui/dom/__tests__/DOMPropertyOperations-test.js
@@ -153,6 +153,21 @@ describe('DOMPropertyOperations', function() {
       expect(stubNode.hasAttribute('allowFullScreen')).toBe(false);
     });
 
+    it('should remove when setting custom attr to null', function() {
+      DOMPropertyOperations.setValueForProperty(
+        stubNode,
+        'data-foo',
+        'bar'
+      );
+      expect(stubNode.hasAttribute('data-foo')).toBe(true);
+      DOMPropertyOperations.setValueForProperty(
+        stubNode,
+        'data-foo',
+        null
+      );
+      expect(stubNode.hasAttribute('data-foo')).toBe(false);
+    });
+
     it('should use mutation method where applicable', function() {
       var foobarSetter = mocks.getMockFunction();
       // inject foobar DOM property