[FLINK-3762] [core] Enable Kryo reference tracking

This closes apache#1891
naraee · Apr 15, 2016 · dc78a74 · dc78a74
1 parent f3d3a44
commit dc78a74
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...k-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoSerializer.java b/...k-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoSerializer.java
@@ -327,9 +327,8 @@ private void checkKryoInitialized() {
 		if (this.kryo == null) {
 			this.kryo = getKryoInstance();
 
-			// disable reference tracking. reference tracking is costly, usually unnecessary, and
-			// inconsistent with Flink's own serialization (which does not do reference tracking)
-			kryo.setReferences(false);
+			// Enable reference tracking. 
+			kryo.setReferences(true);
 
 			// Throwable and all subclasses should be serialized via java serialization
 			kryo.addDefaultSerializer(Throwable.class, new JavaSerializer());

diff --git a/.../java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoGenericTypeSerializerTest.java b/.../java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoGenericTypeSerializerTest.java
@@ -160,9 +160,9 @@ public void testForwardEOFExceptionWhileDeserializing() {
 	}
 
 	@Test
-	public void validateReferenceMappingDisabled() {
+	public void validateReferenceMappingEnabled() {
 		KryoSerializer<String> serializer = new KryoSerializer<>(String.class, new ExecutionConfig());
 		Kryo kryo = serializer.getKryo();
-		assertFalse(kryo.getReferences());
+		assertTrue(kryo.getReferences());
 	}
 }