cifs: don't allow cifs_iget to match inodes of the wrong type

If the type is different from what we think it should be, then don't match the existing inode. Signed-off-by: Jeff Layton <[email protected]> Signed-off-by: Steve French <[email protected]>
naresharelli · Aug 2, 2010 · f30b9c1 · f30b9c1
1 parent 9f84159
commit f30b9c1
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
@@ -724,9 +724,14 @@ cifs_find_inode(struct inode *inode, void *opaque)
 {
 	struct cifs_fattr *fattr = (struct cifs_fattr *) opaque;
 
+	/* don't match inode with different uniqueid */
 	if (CIFS_I(inode)->uniqueid != fattr->cf_uniqueid)
 		return 0;
 
+	/* don't match inode of different type */
+	if ((inode->i_mode & S_IFMT) != (fattr->cf_mode & S_IFMT))
+		return 0;
+
 	/*
 	 * uh oh -- it's a directory. We can't use it since hardlinked dirs are
 	 * verboten. Disable serverino and return it as if it were found, the