Makefile.am: Fix build hang when .git and Git are present but don't w…

…ork. If the .git directory is there, and "git --version" works, but "git ls-files" fails to print any file names (e.g. perhaps because .git is a symlink to an inaccessible directory) then the "grep" command in the thread-safety-check rule would hang forever because it had an empty list of files and therefore expected to read from stdin. This fixes the problem by adding the name of an empty file to the command, which is harmless. Signed-off-by: Ben Pfaff <[email protected]> Acked-by: Alex Wang <[email protected]>
nareshpaturi · Apr 11, 2014 · ca3d034 · ca3d034
1 parent 3cccd40
commit ca3d034
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Makefile.am b/Makefile.am
@@ -247,7 +247,7 @@ thread-safety-check:
 	@if test -e '$(srcdir)'/.git && (git --version) >/dev/null 2>&1 && \
 	   grep -n -f '$(srcdir)'/build-aux/thread-safety-blacklist \
 	       `git ls-files '$(srcdir)' | grep '\.[ch]$$' \
-                | $(EGREP) -v '^datapath|^lib/sflow|^third-party'` \
+                | $(EGREP) -v '^datapath|^lib/sflow|^third-party'` /dev/null \
 	       | $(EGREP) -v ':[ 	]*/?\*'; \
 	then \
 	    echo "See above for list of calls to functions that are"; \