datapath: Fix check-export-symbol for non-bash shells

Avoid using a bash construct (=~) in the target. An alternative would be to make the configure script require bash explicitly. (Currently it doesn't and on NetBSD /bin/ksh is likely used.) The code in question was introduced by commit b296b82 . ("datapath: Check the export of public functions in linux/compat/linux/.") Signed-off-by: YAMAMOTO Takashi <[email protected]> Acked-by: Alex Wang <[email protected]>
nareshpaturi · Apr 28, 2015 · d3de1af · d3de1af
1 parent 26bfaea
commit d3de1af
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/datapath/Makefile.am b/datapath/Makefile.am
@@ -42,19 +42,17 @@ COMPAT_EXPORTS := $(shell $(COMPAT_GET_EXPORTS))
 check-export-symbol:
 	@for fun_ in $(COMPAT_FUNCTIONS); do \
 	   if ! grep -- $${fun_} $(top_srcdir)/datapath/linux/compat/build-aux/export-check-whitelist > /dev/null; then \
-	      if [[ ! $${fun_} =~ ^rpl_* ]] \
-	         && [[ ! $${fun_} =~ ^ovs_* ]]; then \
+	      if ! echo $${fun_} | grep -E '^(rpl|ovs)_'; then \
 	         echo "Should prefix $${fun_} with rpl_ or ovs_."; \
 	         exit 1; \
 	      fi; \
 	   fi; \
 	done
 	@for fun_ in $(COMPAT_EXPORTS); do \
-	   if [[ ! $${fun_} =~ ^rpl_* ]] \
-	      && [[ ! $${fun_} =~ ^ovs_* ]]; then \
+	   if ! echo $${fun_} | grep -E '^(rpl|ovs)_'; then \
 	      echo "Should prefix $${fun_} with rpl_ or ovs_."; \
 	      exit 1; \
 	   fi; \
 	done
 
-all-local: check-export-symbol
+all-local: check-export-symbol