Merge pull request beeware#1 from shyamsunder007/shyamsunder007-patch-1

upadte str.java
narumoto65 · Mar 17, 2017 · 88e5a9b · 88e5a9b
2 parents 090c393 + 757642f
commit 88e5a9b
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/python/common/org/python/types/Str.java b/python/common/org/python/types/Str.java
@@ -715,25 +715,18 @@ public org.python.Object isalnum() {
     }
 
     @org.python.Method(
-            __doc__ = ""
+            __doc__ = "S.isalpha() -> bool\n\n returns false when the string has atleast ONE non letter or if it is empty."
     )
     public org.python.Object isalpha() {
-        int c = 0;
-        java.lang.String checkString = this.value;
-        char currentCharacter;
-
-        if (checkString.length() == 0) {
-            return new org.python.types.Bool(false);
-        } else {
-            while (c < (checkString.length())) {
-                currentCharacter = checkString.charAt(c);
-                if (!Character.isLetter(currentCharacter)) {
+        if (!this.value.isEmpty()) {
+            for (char ch : this.value.toCharArray()) {
+                if (!(Character.isLetter(ch))) {
                     return new org.python.types.Bool(false);
                 }
-                c++;
             }
+            return new org.python.types.Bool(true);
         }
-        return new org.python.types.Bool(true);
+        return new org.python.types.Bool(false);
     }
 
     @org.python.Method(