Update Laravel 8

Summary:
Update to Laravel 8

Ref T1725

Reviewers: dereckson

Reviewed By: dereckson

Subscribers: dereckson

Tags: #user-dorianwinty

Maniphest Tasks: T1725

Differential Revision: https://devcentral.nasqueron.org/D2674

.arclint

@@ -28,8 +28,12 @@
     "phpcs": {
       "type": "phpcs",
       "bin": "vendor/bin/phpcs",
-      "phpcs.standard": "PSR1",
-      "include": "(^app/.*\\.php$)"
+      "phpcs.standard": "phpcs.xml",
+      "include": [
+        "(app/.*\\.php$)",
+        "(config/.*\\.php$)",
+        "(tests/.*\\.php$)"
+      ]
     },
     "spelling": {
       "type": "spelling"

app/Analyzers/BasePayloadAnalyzer.php

@@ -2,10 +2,9 @@
 
 namespace Nasqueron\Notifications\Analyzers;
 
-use Config;
-use Storage;
-
 use BadMethodCallException;
+use Illuminate\Support\Facades\Config;
+use Illuminate\Support\Facades\Storage;
 
 abstract class BasePayloadAnalyzer {
 
@@ -36,7 +35,7 @@ abstract class BasePayloadAnalyzer {
 
     /**
      * The configuration for the payload analyzer
-     * @var PayloadAnalyzerConfiguration;
+     * @var PayloadAnalyzerConfiguration
      */
     protected $configuration;
 
@@ -80,7 +79,7 @@ public function getConfigurationFileName () : string {
 
         $filename = $dir . '/' . $this->project . '.json';
 
-        if (!Storage::has($filename)) {
+        if (!Storage::exists($filename)) {
             return $dir . '/' . static::CONFIG_DEFAULT_FILE;
         }
 

app/Analyzers/DockerHub/BuildFailureEvent.php

@@ -2,7 +2,7 @@
 
 namespace Nasqueron\Notifications\Analyzers\DockerHub;
 
-use Mailgun;
+use Nasqueron\Notifications\Facades\Mailgun;
 
 class BuildFailureEvent extends BaseEvent {
 

app/Analyzers/GitHub/Events/Event.php

@@ -33,8 +33,12 @@ public function __construct ($payload) {
      * @param string $eventName The event name (e.g. commit_comment)
      * @return string The event class name (e.g. CommitCommentEvent)
      */
-    public static function getClass ($eventName) {
-        return __NAMESPACE__ . '\\' . studly_case($eventName) . 'Event';
+    public static function getClass (string $eventName) {
+        return __NAMESPACE__ . '\\' . self::toCamelCase($eventName) . 'Event';
+    }
+
+    private static function toCamelCase (string $string) : string {
+        return str_replace(" ", "", ucwords(str_replace("_", " ", $string)));
     }
 
     /**
@@ -43,7 +47,7 @@ public static function getClass ($eventName) {
      * @param string $eventName The event name (e.g. commit_comment)
      * @return Event
      */
-    public static function forPayload ($eventName, $payload) {
+    public static function forPayload (string $eventName, $payload) {
         $class = self::getClass($eventName);
         if (!class_exists($class)) {
             throw new \InvalidArgumentException(
@@ -60,11 +64,15 @@ public static function forPayload ($eventName, $payload) {
     /**
      * Cuts a text
      *
-     * @param string $text The text to cut
-     * @param int $strLen The amount of characters to allow [optional]
+     * @param string $text   The text to cut
+     * @param int    $strLen The amount of characters to allow [optional]
      * @param string $symbol The symbol to append to a cut text [optional]
      */
-    public static function cut ($text, $strLen = 114, $symbol = '…') {
+    public static function cut (
+        string $text,
+        int    $strLen = 114,
+        string $symbol = '…'
+    ) {
         $len = strlen($text);
         if ($len <= $strLen) {
             return $text;

app/Analyzers/GitHub/Events/IssueCommentEvent.php

@@ -15,7 +15,7 @@ class IssueCommentEvent extends Event {
      * @param string $action The action to check
      * @return bool true if the action is valid; otherwise, false
      */
-    protected static function isValidAction ($action) {
+    protected static function isValidAction (string $action) {
         $actions = ['created', 'edited', 'deleted'];
         return in_array($action, $actions);
     }
@@ -62,4 +62,3 @@ public function getLink () : string {
     }
 
 }
-

app/Analyzers/GitHub/Events/PullRequestEvent.php

@@ -15,7 +15,7 @@ class PullRequestEvent extends Event {
      * @param string $action The action to check
      * @return bool true if the action is valid; otherwise, false
      */
-    protected static function isValidAction ($action) {
+    protected static function isValidAction(string $action) {
         $actions = [
             'assigned', 'unassigned',
             'labeled', 'unlabeled',

app/Analyzers/GitHub/Events/PushEvent.php

@@ -18,7 +18,7 @@ class PushEvent extends Event {
      * @param int $count The count of commits
      * @return string The l10n message key for description
      */
-    private static function getDescriptionMessageKey ($count) {
+    private static function getDescriptionMessageKey (int $count) {
         $key = 'GitHub.EventsDescriptions.PushEvent';
 
         if ($count === 0) {

app/Analyzers/GitHub/Events/WithRef.php

@@ -19,7 +19,7 @@ trait WithRef {
      * @param string $type The ref type to check
      * @return bool true if the ref type id valid; otherwise, false
      */
-    protected static function isValidRefType ($type) {
+    protected static function isValidRefType (string $type) {
         $types = ['branch', 'tag'];
         return in_array($type, $types);
     }
@@ -30,7 +30,7 @@ protected static function isValidRefType ($type) {
      * @param string $type The reference type
      * @return string the part of the URL for this reference type (e.g. /tree/)
      */
-    protected function getLinkRefSegment ($type) {
+    protected function getLinkRefSegment (string $type) {
         $segments = $this->getLinkRefSegments();
 
         if (!array_key_exists($type, $segments)) {

app/Analyzers/GitHub/Events/WithRepoAndBranch.php

@@ -28,7 +28,7 @@ public static function getRepositoryAndBranch (
             return "";
         }
 
-        if (starts_with($branch, "refs/heads/")) {
+        if (str_starts_with($branch, "refs/heads/")) {
             $branch = substr($branch, 11);
         }
 

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

@@ -26,7 +26,7 @@ class GitHubPayloadAnalyzer extends BasePayloadAnalyzer {
     /**
      * The payload analyzer event
      *
-     * @var \Nasqueron\Notifications\Analyzers\GitHub\Events\Event;
+     * @var \Nasqueron\Notifications\Analyzers\GitHub\Events\Event
      */
     private $analyzerEvent;
 

app/Analyzers/ItemGroupMapping.php

@@ -2,6 +2,8 @@
 
 namespace Nasqueron\Notifications\Analyzers;
 
+use Illuminate\Support\Str;
+
 /**
  * Map items (repositories, projects, items, etc.) names to groups
  */
@@ -42,7 +44,7 @@ public static function doesItemMatch (
         string $pattern,
         string $item
     ) : bool {
-        return str_is($pattern, $item);
+        return Str::is($pattern, $item);
     }
 
     /**

app/Analyzers/Jenkins/JenkinsPayloadAnalyzer.php

@@ -31,7 +31,7 @@ public function getItemName () : string {
     /**
      * Tries to get build status.
      *
-     * @param out string $status
+     * @param out string &$status
      * @return bool indicates if the build status is defined in the payload
      */
     private function tryGetBuildStatus (string &$status) : bool {

app/Config/Features.php

@@ -2,7 +2,7 @@
 
 namespace Nasqueron\Notifications\Config;
 
-use Config;
+use Illuminate\Support\Facades\Config;
 
 /**
  * The features class offers a sugar syntax to check if a feature is enabled

app/Config/Reporting/ConfigReport.php

@@ -4,8 +4,8 @@
 
 use Nasqueron\Notifications\Config\Features;
 
-use Config;
-use Services;
+use Nasqueron\Notifications\Facades\Services;
+use Illuminate\Support\Facades\Config;
 
 class ConfigReport {
 

app/Config/Reporting/ServiceReportEntry.php

@@ -4,7 +4,7 @@
 
 use Nasqueron\Notifications\Config\Services\Service;
 
-use ProjectsMap;
+use Nasqueron\Notifications\Facades\ProjectsMap;
 
 final class ServiceReportEntry extends BaseReportEntry {
 

app/Config/Services/Services.php

@@ -2,7 +2,7 @@
 
 namespace Nasqueron\Notifications\Config\Services;
 
-use Storage;
+use Illuminate\Support\Facades\Storage;
 
 class Services {
 

app/Console/Commands/ConfigValidate.php

@@ -4,8 +4,7 @@
 
 use Illuminate\Console\Command;
 use Illuminate\Filesystem\FilesystemAdapter;
-
-use App;
+use Illuminate\Support\Facades\App;
 
 class ConfigValidate extends Command {
 

app/Console/Commands/PhabricatorProjectsMap.php

@@ -4,8 +4,8 @@
 
 use Illuminate\Console\Command;
 
-use ProjectsMap;
-use Services;
+use Nasqueron\Notifications\Facades\ProjectsMap;
+use Nasqueron\Notifications\Facades\Services;
 
 class PhabricatorProjectsMap extends Command {
     /**

app/Contracts/APIClient.php

@@ -10,7 +10,7 @@ interface APIClient {
      * @param string $url The API end point URL
      * @return void
      */
-    public function setEndPoint ($url);
+    public function setEndPoint (string $url);
 
     /**
      * Calls an API method
@@ -19,6 +19,6 @@ public function setEndPoint ($url);
      * @param array $arguments The arguments to use
      * @return mixed The API result
      */
-    public function call ($method, $arguments = []);
+    public function call (string $method, array $arguments = []);
 
 }

app/Contracts/APIFactory.php

@@ -10,6 +10,6 @@ interface APIFactory {
      * @param string $endPoint The API end point
      * @return APIClient
      */
-    public function get ($endPoint);
+    public function get (string $endPoint);
 
 }

app/Events/DockerHubPayloadEvent.php

@@ -2,7 +2,6 @@
 
 namespace Nasqueron\Notifications\Events;
 
-use Nasqueron\Notifications\Events\Event;
 use Illuminate\Queue\SerializesModels;
 
 class DockerHubPayloadEvent extends Event {

app/Events/GitHubPayloadEvent.php

@@ -2,7 +2,6 @@
 
 namespace Nasqueron\Notifications\Events;
 
-use Nasqueron\Notifications\Events\Event;
 use Illuminate\Queue\SerializesModels;
 
 class GitHubPayloadEvent extends Event {

app/Events/JenkinsPayloadEvent.php

@@ -2,7 +2,6 @@
 
 namespace Nasqueron\Notifications\Events;
 
-use Nasqueron\Notifications\Events\Event;
 use Illuminate\Queue\SerializesModels;
 
 class JenkinsPayloadEvent extends Event {

app/Events/NotificationEvent.php

@@ -2,7 +2,6 @@
 
 namespace Nasqueron\Notifications\Events;
 
-use Nasqueron\Notifications\Events\Event;
 use Nasqueron\Notifications\Notifications\Notification;
 
 use Illuminate\Queue\SerializesModels;

app/Events/PhabricatorPayloadEvent.php

@@ -2,8 +2,8 @@
 
 namespace Nasqueron\Notifications\Events;
 
-use Nasqueron\Notifications\Events\Event;
 use Nasqueron\Notifications\Phabricator\PhabricatorStory;
+
 use Illuminate\Queue\SerializesModels;
 
 class PhabricatorPayloadEvent extends Event {

app/Events/ReportEvent.php

@@ -3,7 +3,7 @@
 namespace Nasqueron\Notifications\Events;
 
 use Nasqueron\Notifications\Actions\Action;
-use Nasqueron\Notifications\Events\Event;
+
 use Illuminate\Queue\SerializesModels;
 
 class ReportEvent extends Event {

app/Exceptions/Handler.php

@@ -2,19 +2,18 @@
 
 namespace Nasqueron\Notifications\Exceptions;
 
-use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Nasqueron\Notifications\Facades\Raven;
 
 use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
-use Illuminate\Foundation\Validation\ValidationException;
+use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Validation\ValidationException;
 use Illuminate\Session\TokenMismatchException;
+use Illuminate\Support\Facades\Config;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Console\Exception\CommandNotFoundException;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 
-use Config;
-use Raven;
-
 use Exception;
 
 class Handler extends ExceptionHandler {
@@ -38,9 +37,11 @@ class Handler extends ExceptionHandler {
      *
      * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
      *
-     * @param \Exception $e
+     * @param \Exception|\Throwable $e
+     *
+     * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
-    public function report(Exception $e) : void {
+    public function report(Exception|\Throwable $e) : void {
         if (!$this->shouldReport($e)) {
             return;
         }

app/Facades/Raven.php

@@ -2,10 +2,9 @@
 
 namespace Nasqueron\Notifications\Facades;
 
+use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\Facade;
 
-use Config;
-
 /**
  * @see \Raven_Client
  */

app/Http/Controllers/Controller.php

@@ -2,12 +2,14 @@
 
 namespace Nasqueron\Notifications\Http\Controllers;
 
+use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
-use Illuminate\Routing\Controller as BaseController;
 use Illuminate\Foundation\Validation\ValidatesRequests;
-use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
+use Illuminate\Routing\Controller as BaseController;
 
 abstract class Controller extends BaseController {
 
-    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;
+    use AuthorizesRequests;
+    use DispatchesJobs;
+    use ValidatesRequests;
 }