Add support for workspace folders #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the file path of the buffer which triggered the server to start to decide the first workspace root. In the case of a server restart, remember the file that was open when the restart command was issued. - Add a `lsc#workspace#findMarker` utility function to search upwards from a file to a directory which contains some other file that marks the "root" for that project. TODO: - Add docs. - Check capabilities before sending the message. - Figure out if removing roots is necessary. This would require tracking per-server lists of files. - Allow giving a name to the roots. - Implement the `workspace/workspaceFolders` request. Potential future support - A known file like `.lsc_root` to reliably locally mark the root for any given workspace. - Support for user specific project roots, or perhaps just support the common ones from the start, like `.git/`
- Add a stub for `lsc#workspace#byMarker()` to make it easier to write the tests. - Read client capabilities in `StubServer`. - Outline some tests. Add a test reading client capabilities.
Report stderr for vim.expr (might be helpful in other places too). Fix the bug surfaced by this output with an extra closing paren. Send an extra "<cr>" since the multiple sendKeys seem to leave vim in a state with a "Press Enter to continue", maybe where it prints the function that was just created?
|
@natebosch I would be curious to hear your thoughts on this vim/vim#7748. Feel free to directly comment on the vim github issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.