forked from cadence-workflow/cadence
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixed timer queue processor goroutine leak in test (cadence-workflow#…
…5857) What changed? Correctly stop timer queue processor in the unit test added basic start stop test on transfer queue processor Why? Previously in initialized state, stopping timer queue processor will not stop the timer gate which has a daemon loop; although this shall never happen in production, it's causing go routine leak in unit tests How did you test it? unit test
- Loading branch information
1 parent
f5fde92
commit 4d34cfb
Showing
4 changed files
with
132 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| // The MIT License (MIT) | ||
|
|
||
| // Copyright (c) 2017-2020 Uber Technologies Inc. | ||
|
|
||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all | ||
| // copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| package queue | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
| "go.uber.org/goleak" | ||
|
|
||
| "github.com/uber/cadence/common/persistence" | ||
| "github.com/uber/cadence/common/reconciliation/invariant" | ||
| "github.com/uber/cadence/service/history/config" | ||
| "github.com/uber/cadence/service/history/execution" | ||
| "github.com/uber/cadence/service/history/reset" | ||
| "github.com/uber/cadence/service/history/shard" | ||
| "github.com/uber/cadence/service/history/task" | ||
| "github.com/uber/cadence/service/history/workflowcache" | ||
| "github.com/uber/cadence/service/worker/archiver" | ||
| ) | ||
|
|
||
| func TestTransferQueueProcessor_RequireStartStop(t *testing.T) { | ||
| // some goroutine leak not from this test | ||
| defer goleak.VerifyNone(t) | ||
| ctrl := gomock.NewController(t) | ||
| mockShard := shard.NewTestContext( | ||
| t, ctrl, &persistence.ShardInfo{ | ||
| ShardID: 10, | ||
| RangeID: 1, | ||
| TransferAckLevel: 0, | ||
| }, | ||
| config.NewForTest()) | ||
| defer mockShard.Finish(t) | ||
|
|
||
| mockProcessor := task.NewMockProcessor(ctrl) | ||
| mockResetter := reset.NewMockWorkflowResetter(ctrl) | ||
| mockArchiver := &archiver.ClientMock{} | ||
| mockInvariant := invariant.NewMockInvariant(ctrl) | ||
| mockWorkflowCache := workflowcache.NewMockWFCache(ctrl) | ||
| ratelimit := func(domain string) bool { return false } | ||
|
|
||
| // Create a new transferQueueProcessor | ||
| processor := NewTransferQueueProcessor( | ||
| mockShard, | ||
| mockShard.GetEngine(), | ||
| mockProcessor, | ||
| execution.NewCache(mockShard), | ||
| mockResetter, | ||
| mockArchiver, | ||
| mockInvariant, | ||
| mockWorkflowCache, | ||
| ratelimit) | ||
| processor.Start() | ||
| processor.Stop() | ||
| } |