Fix trace case with tsconfig/jsconfig baseUrl (vercel#30286)

natew · Oct 25, 2021 · 73fbd69 · 73fbd69
1 parent 0910e8b
commit 73fbd69
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 0 deletions.
diff --git a/packages/next/build/webpack/plugins/next-trace-entrypoints-plugin.ts b/packages/next/build/webpack/plugins/next-trace-entrypoints-plugin.ts
@@ -476,10 +476,12 @@ export class TraceEntryPointsPlugin implements webpack5.WebpackPluginInstance {
 
         const CJS_RESOLVE_OPTIONS = {
           ...NODE_RESOLVE_OPTIONS,
+          modules: undefined,
           extensions: undefined,
         }
         const ESM_RESOLVE_OPTIONS = {
           ...NODE_ESM_RESOLVE_OPTIONS,
+          modules: undefined,
           extensions: undefined,
         }
 

diff --git a/test/integration/jsconfig-baseurl/test/index.test.js b/test/integration/jsconfig-baseurl/test/index.test.js
@@ -8,6 +8,7 @@ import {
   findPort,
   launchApp,
   killApp,
+  nextBuild,
   check,
 } from 'next-test-utils'
 
@@ -61,4 +62,21 @@ describe('TypeScript Features', () => {
       expect(found).toBe(true)
     })
   })
+
+  describe('should build', () => {
+    beforeAll(async () => {
+      await nextBuild(appDir)
+    })
+    it('should trace correctly', async () => {
+      const helloTrace = await fs.readJSON(
+        join(appDir, '.next/server/pages/hello.js.nft.json')
+      )
+      expect(
+        helloTrace.files.some((file) => file.includes('components/world.js'))
+      ).toBe(true)
+      expect(
+        helloTrace.files.some((file) => file.includes('react/index.js'))
+      ).toBe(true)
+    })
+  })
 })
diff --git a/test/integration/jsconfig-paths/test/index.test.js b/test/integration/jsconfig-paths/test/index.test.js
@@ -7,6 +7,7 @@ import {
   renderViaHTTP,
   findPort,
   launchApp,
+  nextBuild,
   killApp,
   check,
 } from 'next-test-utils'
@@ -78,4 +79,50 @@ describe('TypeScript Features', () => {
       expect(found).toBe(true)
     })
   })
+
+  describe('should build', () => {
+    beforeAll(async () => {
+      await nextBuild(appDir)
+    })
+    it('should trace correctly', async () => {
+      const singleAliasTrace = await fs.readJSON(
+        join(appDir, '.next/server/pages/single-alias.js.nft.json')
+      )
+      const wildcardAliasTrace = await fs.readJSON(
+        join(appDir, '.next/server/pages/wildcard-alias.js.nft.json')
+      )
+      const resolveOrderTrace = await fs.readJSON(
+        join(appDir, '.next/server/pages/resolve-order.js.nft.json')
+      )
+      const resolveFallbackTrace = await fs.readJSON(
+        join(appDir, '.next/server/pages/resolve-fallback.js.nft.json')
+      )
+      const basicAliasTrace = await fs.readJSON(
+        join(appDir, '.next/server/pages/basic-alias.js.nft.json')
+      )
+      expect(
+        singleAliasTrace.files.some((file) =>
+          file.includes('components/hello.js')
+        )
+      ).toBe(true)
+      expect(
+        wildcardAliasTrace.files.some((file) =>
+          file.includes('mypackage/myfile.js')
+        )
+      ).toBe(true)
+      expect(
+        resolveOrderTrace.files.some((file) => file.includes('lib/a/api.js'))
+      ).toBe(true)
+      expect(
+        resolveFallbackTrace.files.some((file) =>
+          file.includes('lib/b/b-only.js')
+        )
+      ).toBe(true)
+      expect(
+        basicAliasTrace.files.some((file) =>
+          file.includes('components/world.js')
+        )
+      ).toBe(true)
+    })
+  })
 })