Skip to content

Commit

Permalink
Fix Lint/UselessAccessModifier warnings reported by rubocop.
Browse files Browse the repository at this point in the history
  • Loading branch information
tejasbubane committed May 22, 2015
1 parent a0b554f commit c80303b
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 12 deletions.
4 changes: 0 additions & 4 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 3
Lint/UselessAccessModifier:
Enabled: false

# Offense count: 30
Lint/UselessAssignment:
Enabled: false
Expand Down
2 changes: 0 additions & 2 deletions lib/app/presenters/tracks.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ def self.planned
@@planned ||= tracks.select(&:planned?)
end

private

def self.fetch_tracks
status, body = Xapi.get("tracks")
if status != 200
Expand Down
2 changes: 0 additions & 2 deletions lib/exercism/submission.rb
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,6 @@ def participant_submissions(current_user = nil)
end
end

private

# Experiment: Cache the iteration number so that we can display it
# on the dashboard without pulling down all the related versions
# of the submission.
Expand Down
3 changes: 0 additions & 3 deletions lib/exercism/submission_status.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ def self.users_who_have_completed_or_are_working_on(problem, user_relation: nil)
user_relation.includes(:submissions).where(*working_or_done_sql_query(problem)).references(:submissions)
end

private

def self.completed_problem_hash(problem)
{
:language => problem.track_id,
Expand Down Expand Up @@ -65,4 +63,3 @@ def self.working_or_done_sql_query(problem)
end

end

2 changes: 1 addition & 1 deletion lib/jobs/hello.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class Hello
include Sidekiq::Worker
sidekiq_options :queue => :hello

def perform(submission_uuid)
def perform(_)
# This exists solely to get the job scheduled.
# There is a stand-alone worker that processes
# the jobs.
Expand Down

0 comments on commit c80303b

Please sign in to comment.