Improve bash completion for users and groups

Signed-off-by: Harald Albers <[email protected]>
ncdc · Jan 28, 2016 · 0e5ea96 · 0e5ea96
1 parent 725b5b5
commit 0e5ea96
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/contrib/completion/bash/docker b/contrib/completion/bash/docker
@@ -535,6 +535,15 @@ __docker_complete_signals() {
 	COMPREPLY=( $( compgen -W "${signals[*]} ${signals[*]#SIG}" -- "$( echo $cur | tr '[:lower:]' '[:upper:]')" ) )
 }
 
+__docker_complete_user_group() {
+	if [[ $cur == *:* ]] ; then
+		COMPREPLY=( $(compgen -g -- "${cur#*:}") )
+	else
+		COMPREPLY=( $(compgen -u -S : -- "$cur") )
+		__docker_nospace
+	fi
+}
+
 # global options that may appear after the docker command
 _docker_docker() {
 	local boolean_options="
@@ -851,12 +860,7 @@ _docker_daemon() {
 			return
 			;;
 		--userns-remap)
-			if [[ $cur == *:* ]] ; then
-				COMPREPLY=( $(compgen -g -- "${cur#*:}") )
-			else
-				COMPREPLY=( $(compgen -u -S : -- "$cur") )
-				__docker_nospace
-			fi
+			__docker_complete_user_group
 			return
 			;;
 		$(__docker_to_extglob "$options_with_args") )
@@ -995,6 +999,7 @@ _docker_exec() {
 
 	case "$prev" in
 		--user|-u)
+			__docker_complete_user_group
 			return
 			;;
 	esac
@@ -1769,6 +1774,10 @@ _docker_run() {
 			esac
 			return
 			;;
+		--user|-u)
+			__docker_complete_user_group
+			return
+			;;
 		--volume-driver)
 			__docker_complete_plugins Volume
 			return