Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/webservice error handling #426

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Nov 4, 2022

The passcode rules issue should already be fixed by #404. However, the error responses were coming back as XML instead of JSON in some cases. This change will always request JSON instead of accepting the default response format. We also add the specific error messages, if they exist, so the user has enough information to hopefully address the cause of the issue.

Fixes #424

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Nov 4, 2022
@jrchamp jrchamp requested a review from a team November 4, 2022 18:32
@jrchamp jrchamp self-assigned this Nov 4, 2022
Copy link
Contributor

@rickbeasley rickbeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jrchamp jrchamp merged commit be583d6 into ncstate-delta:main Nov 10, 2022
@jrchamp jrchamp deleted the fix/webservice-error-handling branch November 10, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Passcode field rules do not reflect passcode policy from Zoom server
2 participants