Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace removed zoom api id with zoom user id #438

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Replace removed zoom api id with zoom user id #438

merged 1 commit into from
Dec 17, 2022

Conversation

smbader
Copy link
Contributor

@smbader smbader commented Dec 16, 2022

Bug identified by issue #435.
Regression from pull request #422.

The zoom api identifier was removed from use and should be the zoom user id.

@smbader smbader requested a review from jrchamp December 16, 2022 18:19
@smbader smbader self-assigned this Dec 16, 2022
@smbader smbader added the bug Fixes problems or reduces technical debt label Dec 16, 2022
@jrchamp jrchamp linked an issue Dec 17, 2022 that may be closed by this pull request
Undefined variable zoomapiidentifier #435
Closed
jrchamp
jrchamp approved these changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I totally missed that use of the variable somehow.

@jrchamp jrchamp merged commit d879442 into main Dec 17, 2022
@jrchamp jrchamp deleted the issue-435 branch December 17, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchamp jrchamp jrchamp approved these changes

Assignees

@smbader smbader

Labels
bug Fixes problems or reduces technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined variable zoomapiidentifier
2 participants
@smbader @jrchamp