-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration validation based on Zoom account permissions #453
Registration validation based on Zoom account permissions #453
Conversation
Registration validation based on Zoom account permissions
Hi @paulandm Thank you for opening this pull request. It looks like this code is checking if the current user has the Owner role in Zoom. That may not be the most universal way to check if registration is possible in a user's Zoom meetings. Is this restriction implementation specific to your organization's needs? Or is there a more universal way that this could be implemented? |
Hi @jrchamp , thanks for taking a look at this. |
Hi @paulandm I've been researching how registration works and I agree that there does not appear to be specific information in the API or the Zoom settings for who can and cannot register. The best resource that I have found is https://support.zoom.us/hc/en-us/articles/211579443-Scheduling-and-customizing-a-meeting-with-registration
So the user's |
Hi @jrchamp |
That makes sense to me. So instead of the current code, we need to make sure that the host is Licensed if we are planning to show the registration option. And for safety, we should set moodle-mod_zoom/classes/webservice.php Lines 630 to 632 in 6673a2d
So this will go between line 631 and 632 if ($zoom->registration != ZOOM_REGISTRATION_OFF) {
$data['settings']['use_pmi'] = false;
} |
Yes @jrchamp , thank you. That sounds good to me. |
This PR can be closed. The above-mentioned changes have been implemented in a new PR: |
Registration validation based on Zoom account permissions