Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth: Check required scopes; use POST data #475

Merged
merged 3 commits into from
Apr 29, 2023
Merged

oauth: Check required scopes; use POST data #475

merged 3 commits into from
Apr 29, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Apr 27, 2023 •
edited
Loading

This should avoid caching tokens that do not have the required scopes. Also, update documentation to make it clear that "You should create a separate Server-to-Server OAuth app for each Moodle install."

Fixes #473
Fixes #474

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Apr 27, 2023
@jrchamp jrchamp self-assigned this Apr 27, 2023
@jrchamp jrchamp requested a review from a team April 28, 2023 15:58
rickbeasley
rickbeasley approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@rickbeasley rickbeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work on the docs.

@jrchamp jrchamp merged commit 72b0425 into ncstate-delta:main Apr 29, 2023
@jrchamp jrchamp deleted the fix/oauth-scope-check branch April 29, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickbeasley rickbeasley rickbeasley approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
None yet
Milestone
No milestone
2 participants
@jrchamp @rickbeasley