Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect group from license borrowing #630

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

izendegi
Copy link

On this PR we

  • Add a new setting to select the Zoom group to protect
  • When recycling licenses, avoid removing license from users belonging to the protected group

settings.php Outdated Show resolved Hide resolved
@smbader smbader added the enhancement Adds new functionality label Dec 5, 2024
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice idea to help avoid unwanted reassignment. A few suggestions to help minimize the negative impacts on users who are not using groups or reassignment.

settings.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
classes/webservice.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
classes/webservice.php Outdated Show resolved Hide resolved
lang/en/zoom.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
@izendegi izendegi force-pushed the ProtectedGroup branch 3 times, most recently from b116bf6 to 4c51fa3 Compare December 20, 2024 14:25
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of your timely updates! This is very nice and should help users who needs this functionality. After applying the suggested changes, please make sure that it is still working as expected on your system (as I believe you may be one of the users of this functionality).

classes/webservice.php Outdated Show resolved Hide resolved
classes/webservice.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
classes/webservice.php Outdated Show resolved Hide resolved
@izendegi
Copy link
Author

Hi, @jrchamp

We've been using the original code for more than a year but haven't tested these last changes extensively (I'm on a leave for a couple of weeks), so please give me some weeks to test them and refine if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality
Projects
Status: No status
Status: Reviewed, changes needed
Development

Successfully merging this pull request may close these issues.

3 participants