-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect group from license borrowing #630
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice idea to help avoid unwanted reassignment. A few suggestions to help minimize the negative impacts on users who are not using groups or reassignment.
b116bf6
to
4c51fa3
Compare
4c51fa3
to
8d1e88d
Compare
fd5c702
to
5eee4e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all of your timely updates! This is very nice and should help users who needs this functionality. After applying the suggested changes, please make sure that it is still working as expected on your system (as I believe you may be one of the users of this functionality).
Co-authored-by: Jonathan Champ <[email protected]>
Co-authored-by: Jonathan Champ <[email protected]>
Hi, @jrchamp We've been using the original code for more than a year but haven't tested these last changes extensively (I'm on a leave for a couple of weeks), so please give me some weeks to test them and refine if needed. |
On this PR we