Skip to content

Commit

Permalink
Rename GPU to raster thread in PerformanceOverlay (flutter#17148)
Browse files Browse the repository at this point in the history
Rename GPU to raster thread in PerformanceOverlay and update goldens.
  • Loading branch information
liyuqian authored Mar 25, 2020
1 parent bb35963 commit 9459670
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion flow/layers/performance_overlay_layer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ void PerformanceOverlayLayer::Paint(PaintContext& context) const {
VisualizeStopWatch(
*context.leaf_nodes_canvas, context.raster_time, x, y, width,
height - padding, options_ & kVisualizeRasterizerStatistics,
options_ & kDisplayRasterizerStatistics, "GPU", font_path_);
options_ & kDisplayRasterizerStatistics, "Raster", font_path_);

VisualizeStopWatch(*context.leaf_nodes_canvas, context.ui_time, x, y + height,
width, height - padding,
Expand Down
2 changes: 1 addition & 1 deletion flow/layers/performance_overlay_layer_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ TEST_F(PerformanceOverlayLayerTest, SimpleRasterizerStatistics) {

layer->Paint(paint_context());
auto overlay_text = PerformanceOverlayLayer::MakeStatisticsText(
paint_context().raster_time, "GPU", "");
paint_context().raster_time, "Raster", "");
auto overlay_text_data = overlay_text->serialize(SkSerialProcs{});
SkPaint text_paint;
text_paint.setColor(SK_ColorGRAY);
Expand Down
Binary file modified testing/resources/performance_overlay_gold_120fps.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified testing/resources/performance_overlay_gold_60fps.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified testing/resources/performance_overlay_gold_90fps.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 9459670

Please sign in to comment.