[IMP] keychain: get_password must not be accessible from outside

nebras-solutions · Feb 6, 2018 · f3df07a · f3df07a
1 parent e359616
commit f3df07a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/keychain/__manifest__.py b/keychain/__manifest__.py
@@ -3,7 +3,7 @@
 {
     "name": "Keychain",
     "summary": "Store accounts and credentials",
-    "version": "11.0.1.0.0",
+    "version": "11.0.2.0.0",
     "category": "Uncategorized",
     "website": "https://akretion.com/",
     "author": "Akretion, Odoo Community Association (OCA)",

diff --git a/keychain/models/keychain.py b/keychain/models/keychain.py
@@ -61,7 +61,7 @@ def _compute_password(self):
         # Only needed in v8 for _description_searchable issues
         return True
 
-    def get_password(self):
+    def _get_password(self):
         """Password in clear text."""
         try:
             return self._decode_password(self.password)

diff --git a/keychain/tests/test_keychain.py b/keychain/tests/test_keychain.py
@@ -67,7 +67,7 @@ def test_password(self):
             account.clear_password = password
             account._inverse_set_password()
             self.assertTrue(account.clear_password != account.password)
-            self.assertEqual(account.get_password(), password)
+            self.assertEqual(account._get_password(), password)
 
     def test_wrong_key(self):
         """It should raise an exception when encoded key != decoded."""
@@ -77,7 +77,7 @@ def test_wrong_key(self):
         account._inverse_set_password()
         config['keychain_key'] = Fernet.generate_key()
         try:
-            account.get_password()
+            account._get_password()
             self.assertTrue(False, 'It should not work with another key')
         except Warning as err:
             self.assertTrue(True, 'It should raise a Warning')
@@ -133,13 +133,13 @@ def test_multienv(self):
         account.clear_password = 'abc'
         account._inverse_set_password()
         self.assertEqual(
-            account.get_password(),
+            account._get_password(),
             'abc', 'Should work with dev')
 
         config['running_env'] = 'prod'
         with self.assertRaises(Warning):
             self.assertEqual(
-                account.get_password(),
+                account._get_password(),
                 'abc', 'Should not work with prod key')
 
     def test_multienv_blank(self):
@@ -153,12 +153,12 @@ def test_multienv_blank(self):
         account.clear_password = 'abc'
         account._inverse_set_password()
         self.assertEqual(
-            account.get_password(),
+            account._get_password(),
             'abc', 'Should work with dev')
 
         config['running_env'] = 'prod'
         self.assertEqual(
-            account.get_password(),
+            account._get_password(),
             'abc', 'Should work with prod')
 
     def test_multienv_force(self):
@@ -177,12 +177,12 @@ def test_multienv_force(self):
 
         with self.assertRaises(Warning):
             self.assertEqual(
-                account.get_password(),
+                account._get_password(),
                 'abc', 'Should not work with dev')
 
         config['running_env'] = 'prod'
         self.assertEqual(
-            account.get_password(),
+            account._get_password(),
             'abc', 'Should work with prod')
 
     def test_wrong_json(self):