Change pin labelling to match IDC connector pinout #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assigning the default 2x05 IDC 2.54mm connector footprint to this symbol, the pins get swapped around so that the 'red stripe' would get connected to +12V, not -12V. In every Eurorack power cable I've looked at, pin 1 (indicated by the subtle arrow on the outside of the connector) aligns with the red stripe and the -12V rail. It's a subtle error, and doesn't matter if you're using unshrouded pin headers and keep track of the pin numbering yourself, but it's very important and potentially hard to catch if you're using the IDC connectors. (Please test this change before integrating. I made the change by hand in GitHub after verifying and fixing the problem on my local machine, so I can't guarantee I haven't made a typo.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning the default 2x05 IDC 2.54mm connector footprint to this symbol, the pins get swapped around so that the 'red stripe' would get connected to +12V, not -12V. In every Eurorack power cable I've looked at, pin 1 (indicated by the subtle arrow on the outside of the connector) aligns with the red stripe and the -12V rail. It's a subtle error, and doesn't matter if you're using unshrouded pin headers and keep track of the pin numbering yourself, but it's very important and potentially hard to catch if you're using the IDC connectors.
(Please test this change before integrating. I made the change by hand in GitHub after verifying and fixing the problem on my local machine, so I can't guarantee I haven't made a typo.)