Skip to content

Commit

Permalink
drivers/mcb: do not set default Kconfig variable to modular
Browse files Browse the repository at this point in the history 
Coverage builds found this build fail in ARM ebsa110_defconfig:

drivers/mcb/mcb-parse.c: In function 'chameleon_parse_cells':
drivers/mcb/mcb-parse.c:105:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mcb/mcb-parse.o] Error 1

A simple bisect will output this:

3764e82 is the first bad commit
commit 3764e82
Author: Johannes Thumshirn <[email protected]>
Date:   Wed Feb 26 17:29:05 2014 +0100

    drivers: Introduce MEN Chameleon Bus

The above commit used "default m" which is wrong.  New drivers
should never be globally enabled with "default y/m".  Whether
this driver makes sense to build on ARM is an independent issue.

Here we delete the "default m" line, which is the equivalent of
"default n".

Cc: Johannes Thumshirn <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
@gregkh
Paul Gortmaker authored and gregkh committed Mar 9, 2014
1 parent aa074c1 commit 0db03f3
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/mcb/Kconfig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

menuconfig MCB
tristate "MCB support"
default m
help

The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik
Expand Down

0 comments on commit 0db03f3

Please sign in to comment.