tpm: Add missing tpm_do_selftest to ST33 I2C driver

Most device drivers do call 'tpm_do_selftest' which executes a TPM_ContinueSelfTest. tpm_i2c_stm_st33 is just pointlessly different, I think it is bug. These days we have the general assumption that the TPM is usable by the kernel immediately after the driver is finished, so we can no longer defer the mandatory self test to userspace. Cc: <[email protected]> # 3.12+ Reported-by: Richard Marciel <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]> Signed-off-by: Peter Huewe <[email protected]>
needcaffeine · Jul 29, 2014 · f07a5e9 · f07a5e9
1 parent 167225b
commit f07a5e9
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/drivers/char/tpm/tpm_i2c_stm_st33.c b/drivers/char/tpm/tpm_i2c_stm_st33.c
@@ -714,6 +714,7 @@ tpm_st33_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	}
 
 	tpm_get_timeouts(chip);
+	tpm_do_selftest(chip);
 
 	dev_info(chip->dev, "TPM I2C Initialized\n");
 	return 0;